All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:35 | maggie_s left #miro-hackers | |
| 00:48 | willkg left #miro-hackers | |
| 02:00 | arpu left #miro-hackers | |
| 02:49 | Odysimus left #miro-hackers | |
| 02:54 | Odysimus joined #miro-hackers | |
| 03:05 | Odysimus left #miro-hackers | |
| 03:16 | Odysimus joined #miro-hackers | |
| 03:23 | odenthaa joined #miro-hackers | |
| 03:25 | Odysimus left #miro-hackers | |
| 04:04 | Odysimus joined #miro-hackers | |
| 04:06 | odenthaa left #miro-hackers | |
| 05:08 | Odysimus left #miro-hackers | |
| 05:12 | egor left #miro-hackers | |
| 05:15 | DGMurdockIII left #miro-hackers | |
| 06:25 | DGMurdockIII joined #miro-hackers | |
| 07:35 | DGMurdockIII left #miro-hackers | |
| 10:32 | egor joined #miro-hackers | |
| 10:55 | janetPCF joined #miro-hackers | |
| 10:57 | Jarrhead joined #miro-hackers | |
| 11:15 | Jarrhead left #miro-hackers | |
| 11:28 | Jarrhead joined #miro-hackers | |
| 12:32 | willkg joined #miro-hackers | |
| 12:32 | willkg | hi! |
| 13:03 | zanoi | have we ever tested miro with a really really big music collection? |
| 13:05 | I just remembered that amarok switched from sqlite to mysql because sqlite couldn't handle big enough music collections | |
| 13:05 | so we might want to check what the max is for miro | |
| 13:06 | willkg | zanoi: what do you mean by "really really big"? what order of magnitude is that? |
| 13:12 | zanoi | I don't know |
| 13:12 | willkg | ok. it's hard to answer the question, then. |
| 13:12 | my music collection is around 3000 items and miro seems ok with that. ben has a music collection that's around 7000 items and it's fine with that. | |
| 13:12 | zanoi | maybe 10 000 songs? maybe more? |
| 13:12 | willkg | beyond that, you should ask janetPCF because she's our QA person. |
| 13:12 | zanoi | janetPCF: ^ |
| 13:13 | i think i vaguely remember 30 000 with the amarok thing | |
| 13:13 | but that might just be me imagining things | |
| 13:16 | janetPCF | zanoi: - I have about 4000, but I can copy it a few times and see how big I can go. |
| 13:22 | willkg | zanoi: so, according to this: http://jefferai.org/2008/10/my[…]ok-2-the-reality/ |
| 13:22 | the issue wasn't really "sqlite can't handle big enough music collections". | |
| 13:23 | one of the paragraphs talks about how people with really large music collections got performace gains when switching to mysql and postgresql, but that's not the same statement. | |
| 13:23 | zanoi | he mentions other reasons as well but slow sqlite performance with big collections is one of the main ones |
| 13:23 | willkg | plus that's 2008. |
| 13:23 | zanoi | but he also doesn't say how big a big collections is |
| 13:23 | willkg | yup. |
| 13:24 | zanoi | janetPCF: yes, that sounds like a good idea |
| 13:24 | willkg | janetPCF: any idea how big nick's collection is? i vaguely remember him having a large collection and it thrashing. |
| 13:24 | thrashing at one point a while back. | |
| 13:25 | zanoi | also with the blog post being from 2008 there are to possibilities: |
| 13:25 | 1. sqlite has improved and it should work better | |
| 13:25 | 2. collections are much bigger and it should be worse | |
| 13:25 | maybe its a combination | |
| 13:25 | *two | |
| 13:26 | willkg | if we have performance issues still, this might be an interesting thing to look at. |
| 13:29 | zanoi: since ben is usually involved with db and performance things, you might want to mention that to him with a link to that blog post. | |
| 13:29 | zanoi | ok |
| 13:31 | i just asked in the amarok channel | |
| 13:32 | willkg | i talked to nightrose. she might be in the amarok channel. |
| 13:33 | zanoi | yes |
| 13:34 | isnt she the release manager or something | |
| 13:34 | well apparently they did switch because of performance | |
| 13:34 | willkg | i don't know. i've been reading her thesis and noticed she mentioned amarok a bunch. |
| 13:34 | zanoi | but "sqlite experts say weshould be fine with sqlite with the right queries/db layout" |
| 13:34 | and it slows down at >10k tracks | |
| 13:35 | and is definitely noticeable with 30k | |
| 13:35 | willkg | definitely worth telling ben. |
| 13:35 | afk a bit for coffee. | |
| 13:53 | bendk joined #miro-hackers | |
| 13:53 | bendk | janetPCF: you around? |
| 13:58 | willkg | bendk: she hasn't said anything since i've been on. |
| 13:59 | bendk: did you take a look at the willclose bug and the changes in the branch? | |
| 13:59 | bendk | I haven't yet |
| 13:59 | let me look at that now | |
| 13:59 | willkg | ok. |
| 14:00 | i'd like to land it today if it looks ok. but it could wait a bit, i suppose. | |
| 14:02 | bendk | seems good to me overall |
| 14:04 | one suggestion is in the GTK delete() method, to check if the window is actually open before calling close() | |
| 14:04 | I don't think will-close should be emitted in that case | |
| 14:04 | I mean in the case where the window is already hidden | |
| 14:06 | other than that, I'd say check it in | |
| 14:08 | the ^C commit seems okay too, but I agree with waiting on that one | |
| 14:08 | I don't quite understand why we need the try...except around gtk.main_quit() since shouldn't the KeyboardInterrupt be caught in the main thread? | |
| 14:09 | I'm sure it's needed, it just seems weird to me | |
| 14:11 | janetPCF | bendk: I"m here - just was working on the other machine |
| 14:12 | can't see the jumping ducky | |
| 14:12 | bendk | do we have a litmus test for upgrading with a bunch of files in your library? |
| 14:13 | I'm working on #16980 and I'm wondering why we haven't caught it yet | |
| 14:13 | it completely kills my machine currently | |
| 14:13 | janetPCF | sure I can |
| 14:13 | bendk | one difference is external drive vs. main drive. We should test both. For that bug, I think the really bad part only happens if miro's videos are on your main drive |
| 14:14 | cool, thanks | |
| 14:18 | janetPCF | bendk: I tested the upgrade with watched folder on external drive |
| 14:19 | and I have about 4000 files, but I can duplicate the data so I have more files. | |
| 14:19 | bendk | yeah, that explains it |
| 14:19 | 4k files should definitely be enough, at least for this bug | |
| 14:25 | willkg | back... |
| 14:25 | the ^C one shouldn't affect anything other than allow me to kill the process with ^C. so i think it's a little weird, but it should be really safe. | |
| 14:26 | bendk: how do you check to see if the window was open? i saw there was a visible property, but i don't think visible and open are the same thing. | |
| 14:28 | bendk | There's is_visible() on gtk.gdk.Window |
| 14:28 | which I think should work | |
| 14:29 | willkg | right... so i wasn't sure if visible and open were the same thing. |
| 14:30 | bendk | I think they should be from reading the docs, but I'm not 100% |
| 14:30 | willkg | ok. |
| 14:32 | ajonas joined #miro-hackers | |
| 14:49 | willkg | mmm... can you get a delete-event if the window isn't visible? |
| 14:49 | bendk: ^^^ | |
| 14:49 | bendk | I don't think so, but maybe |
| 14:49 | * willkg | nods. |
| 14:49 | bendk | It would definitely be a weird case |
| 14:49 | willkg | ok. i'll add that code and test it now. |
| 15:23 | DGMurdockIII joined #miro-hackers | |
| 15:27 | bendk left #miro-hackers | |
| 15:32 | bendk joined #miro-hackers | |
| 15:36 | Jarrhead left #miro-hackers | |
| 15:52 | bendk left #miro-hackers | |
| 15:52 | bendk1 joined #miro-hackers | |
| 15:56 | zanoi | willkg, I don't quite understand why you are doing your branch workflow the way you described in the e-mail. |
| 15:57 | Why don't you let other people just clone your branch to test it? and then you push from your branch to master when its done? | |
| 15:57 | that would save you all the manual patch stuff | |
| 15:57 | bendk1 left #miro-hackers | |
| 15:57 | zanoi | am i missing something? |
| 16:03 | bendk joined #miro-hackers | |
| 16:10 | zanoi | kcw, would you have time to comment on 16914#c3 at some point? |
| 16:12 | willkg, also with clone I obviously mean "git reset" in case people have a clone already, so they wouldn't have to download more than if they applied the patch via e-mail | |
| 16:28 | willkg | zanoi: so, you don't "clone branches" with git. |
| 16:29 | zanoi: the reason to push it to g.p.o. is that it's a central place everyone has access to. | |
| 16:29 | zanoi: beyond that, i'm not sure i understand your question(s). | |
| 16:30 | zanoi | why do you manually create a patch, send it by email, apply it to your master branch, make a new commit and then push that? |
| 16:31 | instead of letting people test your branch and then you push your branch to master | |
| 16:31 | bendk left #miro-hackers | |
| 16:32 | willkg | zanoi: i'm not manually creating patches or sending anything by email.... |
| 16:32 | bendk joined #miro-hackers | |
| 16:33 | zanoi | willkg, so what do the "git format-patch" and "git am" instructions in your e-mail do then? |
| 16:33 | if not creating a patch | |
| 16:34 | willkg | that creates a patch. and like i said in the email, i'm mostly doing that so i have a patch series in an easy to email form and it saves some minor work if i mistype something later on. |
| 16:34 | but it doesn't say that i go email it anywhere. | |
| 16:34 | you could cherry-pick the changes, too. | |
| 16:35 | i just explicitly create patch files as a sort of convenience/insurance thing. | |
| 16:35 | does that make more sense? | |
| 16:35 | zanoi | that would make sense if you weren't manually applying them afterwards |
| 16:39 | willkg | why? is it bad to use git am? |
| 16:40 | zanoi | no, but it's unnecessary |
| 16:40 | willkg | ok. sounds like you shouldn't use my workflow. |
| 16:40 | zanoi | heh. Sounds like a good solution |
| 16:41 | I'm all for using more branches to keep master stable though | |
| 16:43 | however, if we randomly rebase our pushed branches we might want to add a warning in the wiki or somewhere | |
| 16:44 | willkg | we already have a section in the CodingStandards that talks about rebase vs. merge. i think that covers this situation already. it's not "random rebasing". |
| 16:45 | http://develop.participatorycu[…]anches_and_rebase | |
| 16:48 | zanoi | so we are assuming that as long as nobody else has committed to a branch nobody else is working on it? |
| 16:48 | willkg | i think whoever created the branch dictates what happens with it. |
| 16:49 | mostly i don't really care much unless it's a version branch. messing with those is bad for the project. | |
| 16:49 | messing with other branches is a mild inconvenience in collaboration between whoever is working on it. | |
| 16:49 | so when in doubt, communicate communicate communicate. | |
| 16:49 | zanoi | well I just don't want third party people who want to submit a patch against a branch getting their work messed up |
| 16:50 | willkg | me either. but i don't think this creates that problem. |
| 16:52 | afk for a bit for lunch. | |
| 16:53 | zanoi | well if you don't think a merge problem can happen that way, then I guess the problem is solved. |
| 17:28 | willkg | zanoi: when someone submits a patch against a branch that is getting rebased because it's an individual branch, then we can revisit this. |
| 17:28 | zanoi: until then, it's an academic problem. | |
| 17:29 | zanoi | or we could decide on a policy, make a note in the wiki, and the problem is forever solved |
| 17:30 | but I don't really care that much either way | |
| 17:34 | willkg | so, you're suggesting we should create a policy for every possible happenstance no matter how unlikely the scenario is? |
| 17:41 | zanoi | we could for example say: "branches by individual developers can rebase at random, so be prepared for that or drop a note to the developer that you would like to work on that branch as well" |
| 17:42 | willkg | could say that where? and to whom? |
| 17:42 | and these are for branches that have a life time of less than a week. why would someone be fiddling with these branches? | |
| 17:43 | JasonWoof left #miro-hackers | |
| 17:43 | zanoi | to potential contributors who read instructions about how to submit patches |
| 17:43 | willkg | how does someone recognize what is an individual developer branch? |
| 17:44 | zanoi | yes, that's one of the problems I mentioned in the beginning |
| 17:45 | I tried to formulate the policy, as I understood it, that you currently implicitly seem to expect | |
| 17:45 | willkg | i don't see this as a meaningful problem to solve. but i am concerned with the "let's create a policy for all possible problems" issue. i really want to keep the number of policies we have to a minimum and address real problems we've bumped into. |
| 17:45 | zanoi | ok. sure |
| 17:46 | willkg | so, i think that's where i want to leave this conversation. if it turns out not to be an academic problem and we actually have a problem with it, then we can/should adjust the existing policies accordingly. |
| 17:46 | zanoi | sure |
| 18:12 | z3p | deardiary: can't believe we're still getting new design tickets |
| 18:14 | willkg | z3p: no kidding. |
| 18:15 | JasonWoof joined #miro-hackers | |
| 18:19 | willkg | z3p: how're you doing with things? are you blocking on anything? do you have too many things on your plate? where are you at? |
| 18:20 | z3p | willkg: I'm waiting for some log files on bugs I can't reproduce, so I'm looking into admin p.o bugs now |
| 18:20 | willkg | cool. that sounds pretty doable. |
| 18:20 | what do you have for windows environments? do you have a dedicated windows machine? are you mostly using vms? what windows versions do you have available? | |
| 18:21 | z3p | willkg: I just have XP at the moment; I used to have a vista VM but it's on a random backup HD now |
| 18:21 | willkg: XP is on a VM too | |
| 18:21 | willkg | ok. |
| 18:22 | and you have a dedicates osx machine? | |
| 18:22 | z3p | willkg: yes |
| 18:22 | willkg | er, dedicated? |
| 18:22 | what version is that? | |
| 18:22 | is that a mac mini? | |
| 18:22 | z3p | willkg: 10.6 something, I think |
| 18:23 | yeah, 10.6.7 | |
| 18:23 | and yes, mac mini | |
| 18:23 | willkg | did you get a mini the same time i did? i think it was 2008 or 2009. |
| 18:23 | i think i'm going to do a survey and find out which people have which environments available. | |
| 18:24 | z3p | willkg: something like that, yeah |
| 18:25 | willkg: but I upgraded it to snow leopard after we stopped needing to support 10.4 | |
| 18:25 | * willkg | nods. |
| 18:25 | willkg | me, too. |
| 18:27 | ajonas | i have 10.5.8 , fwiw |
| 18:35 | willkg | ajonas: that's good to know. |
| 18:43 | janetPCF | willkg: I have 10.5 on a ppc mini |
| 18:43 | and 10.6 on a macbook with a broken backlight | |
| 18:43 | fyi - FF 4.0 doesn't support ppc | |
| 18:44 | willkg | i know we talked about that, but i can't remember if miro supports ppc anymore, either. |
| 18:44 | janetPCF | I was actually only able to update it from 10.4 because luc mailed me his 10.5 ppc discs and then I mailed them back |
| 18:45 | willkg | i know we talked about it. i think we said we'd ditch it when mozilla did. i don't remember if there was anything we had to do to ditch ppc support and/or if we did it for 4.0. |
| 18:45 | janetPCF | we've never officially decided to drop support on that anywhere |
| 18:45 | willkg | ok. that's probably something we should do for 4.1, then. |
| 18:45 | janetPCF | it still works - but the machine itself is pretty slow and annoying so I don't use it much |
| 19:09 | willkg | janetPCF: sounds exciting. |
| 19:15 | deardiary: working on last bits of will-close issues. | |
| 19:15 | bendk | deardiary: just pushed the importing files changes I've been sucked into for the last day or 2... feels good |
| 19:15 | willkg | bendk: oo... i want to test that out right now. |
| 19:17 | bendk: nice. | |
| 19:17 | bendk | hmm, I forgot to test it with devices |
| 19:18 | *crosses fingers* | |
| 19:18 | willkg | i just did a watched folder. i can test adding my external drive as a device next. |
| 19:19 | bendk | cool, I'll test my thumbdrive too |
| 19:20 | willkg | funky. seems like miro just put a bunch of obvious movie files into the music folder for the device. |
| 19:23 | so weird. so i've got a bunch of videos that are clearly videos (.mp4 and .m4v) that ended up in the music folder. | |
| 19:23 | and they have thumbnails. | |
| 19:23 | maybe i had a .miro folder still around. i'll wipe that out and rebuild it and see what happens. | |
| 19:25 | arpu joined #miro-hackers | |
| 19:25 | CarlFK | willkg: i got pycon vids all cleaned up - no more duplicates |
| 19:25 | willkg | whew. looks like bad data in the .miro folder. all better now. |
| 19:25 | CarlFK: AWESOME! | |
| 19:26 | CarlFK | I have a feeling I broke our lightning talk subs |
| 19:26 | willkg | funny you mention that, someone emailed me about it a couple of days ago. |
| 19:26 | CarlFK | were there any more pycon talks that were transcribed ? |
| 19:26 | willkg | our lightning talk and facunda batista's talk from sunday morning. |
| 19:26 | CarlFK | oh yeah |
| 19:27 | willkg | bendk: i'm getting a ton of KeyError from self._ngrams_for_item crashes. |
| 19:27 | bendk | can you pastebin one? |
| 19:27 | willkg | bendk: sure. |
| 19:28 | bendk: http://pastebin.com/n0MzcQEc | |
| 19:28 | also, doing this import is making my computer really hot. | |
| 19:29 | CarlFK: i'll check out my script and see what the deal is later today and then start importing talks. | |
| 19:29 | CarlFK: i'll also see if i can't pull over the universal subtitles stuff for our talk. if i can't, i'll just re-transcribe it. | |
| 19:30 | CarlFK | groovy |
| 19:30 | willkg | bendk: it'd help if the crash report dialog knew how many crash reports were in the queue and told the user and had a "ignore them all" button. |
| 19:30 | bendk | I think hitting ignore once should do that |
| 19:30 | but it's buggy | |
| 19:30 | willkg | it doesn't. |
| 19:31 | at least, not with these crashes. i think i have to hit it like 60 times to get through them all. | |
| 19:35 | bendk: want me to make that into a bug? | |
| 19:36 | bendk | sure |
| 19:42 | willkg | bendk: 17010. |
| 19:42 | also, we totally blew through janetPCF's "wouldn't it be nice if we had 1000 bugs in the milestone?" | |
| 19:43 | janetPCF | So now we can aim for 1000 FIXED bugs. |
| 19:43 | hahahahahah | |
| 19:43 | willkg | that's a little harder to tell since the roadmap doesn't explicitly say that. |
| 19:44 | i should change the CLOSED section to only include FIXED bugs, though. | |
| 19:44 | we don't really care about the other resolutions. | |
| 19:44 | or statuses... i forget which column it is. | |
| 19:53 | bendk | janetPCF: does the device tab ever have show the importing progress bar? |
| 19:54 | janetPCF | that's a better question for z3p |
| 19:54 | bendk | z3p: ^^^ |
| 19:54 | janetPCF | I can't think of it right now - I usually don't have much stuff on my device |
| 19:54 | and my big drive won't work on windows today | |
| 19:55 | willkg | bendk: i've never seen an importing progress bar. |
| 19:55 | bendk | that's what it looks like to me from the code, just wanted to double check |
| 19:55 | willkg | bendk: er, let me clarify. i've never seen an importing progress bar for devices. |
| 19:56 | ok. that close/destroy stuff looks ok now. i'm going to land that now. | |
| 20:07 | deardiary: will-close fixes landed. whew. | |
| 20:07 | on to greener pastures! | |
| 20:10 | bendk: want me to re-test massive device import things? | |
| 20:10 | bendk | sure |
| 20:10 | I don't think 17010 was caused by the import code though | |
| 20:11 | willkg | i don't know. but i'll find out now if i can reproduce it. :) |
| 20:13 | hrm. it's weird now. | |
| 20:13 | bendk | are you seeing it still? |
| 20:13 | willkg | i start up miro, i click the "see all my devices" thing to on, and miro goes off and does stuff, but there's nothing going on in the interface. |
| 20:14 | i'm seeing a lot of "idle (scan_device_for_files()..." messages. | |
| 20:14 | oh. now the stuff is showing up. | |
| 20:14 | so, it takes about a minute for the interface to reflect that there's stuff on my drive. it didn't do that before. | |
| 20:15 | bendk | hmm, that's probably because we're now running mutagen on the files before we create items for them |
| 20:15 | willkg | plus, i fixed the device item titles so they didn't have the filename extension. looks like that got unfixed. |
| 20:16 | bendk | do you not see anything at all, then all of them at once? |
| 20:16 | willkg | yes. the interface shows me nothing... then about a minute later, a bunch of stuff shows up. i don't know if it's all the items or a subset of the items, though. |
| 20:17 | bendk | I think it's from my changes, I'll probably have to talk with z3p more about the right way to go about things |
| 20:17 | * willkg | nods. |
| 20:17 | willkg | i'm not seeing the crashes i saw earlier, though. (at least not yet) |
| 20:18 | bendk | If you don't see them again, can you mark it invalid? |
| 20:18 | I'm trying to think of a way that that would happen and I can't | |
| 20:18 | unless there's more data, I'm not sure what to do | |
| 20:19 | willkg | i'll definitely update that bug with my most recent experiences. |
| 20:19 | interesting. i have "Why can't a woman be more like a man" on this drive. | |
| 20:19 | i didn't realize i had My Fair Lady on here. | |
| 20:33 | bendk left #miro-hackers | |
| 20:39 | morganknutson joined #miro-hackers | |
| 20:47 | willkg | janetPCF: you on? |
| 20:47 | janetPCF | yes I am |
| 20:48 | willkg | if i remove -crf 22 and add -vpre ipod640, then i get an error from ffmpeg: "Error while opening encoder for output stream #0.0 - maybe incorrect parameters such as bit_rate, rate, width or height" |
| 20:49 | i can do a conversion to epic which has the original parameters. so it's definitely the change to -crf 22 or -vpre ipod640 that's causing the problem. | |
| 20:49 | bah. scratch that. | |
| 20:49 | bloody typo. | |
| 20:50 | i'll check this change in now. | |
| 20:50 | janetPCF | thanks god for typos - you had me seriously doubting myself |
| 20:51 | willkg | i really apologize. |
| 20:51 | i should have double checked. | |
| 21:03 | Odysimus joined #miro-hackers | |
| 21:10 | DGMurdockIII left #miro-hackers | |
| 21:39 | maggie_s joined #miro-hackers | |
| 21:41 | ajonas | maggie_s: hi! |
| 21:41 | maggie_s | ajonas: hi! |
| 21:50 | egor left #miro-hackers | |
| 22:18 | Odysimus left #miro-hackers | |
| 22:23 | Odysimus joined #miro-hackers | |
| 22:46 | ajonas left #miro-hackers | |
| 23:41 | willkg | i'm done for the evening. going to go take my pants of, kick my feet up, and watch the street sweeper sweeping up the gobs of sand they threw on the road during the winter. |
| 23:41 | that's entertainment in the suburbs.... | |
| 23:41 | later! | |
| 23:41 | willkg left #miro-hackers | |
| 23:45 | janetPCF left #miro-hackers | |
| 23:58 | maggie_s left #miro-hackers |
p.o bugs now