All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:07 | willkg | glee: you on? |
| 00:07 | glee: i was copying the multiple case for context menus. pretty sure that also allows you to add to a playlist for remote items. | |
| 00:07 | glee: can you double-check that? | |
| 00:08 | glee: it's around line 366 in itemcontextmenu.py. | |
| 00:23 | paroneayea left #miro-hackers | |
| 00:23 | glee left #miro-hackers | |
| 00:24 | glee joined #miro-hackers | |
| 00:30 | paroneayea joined #miro-hackers | |
| 00:31 | paroneayea left #miro-hackers | |
| 00:32 | paroneayea joined #miro-hackers | |
| 00:48 | willkg | bendk1: do you have to quit miro and restart it after enabling/disabling Small Monitor Mode? |
| 02:10 | time for me to jet. see you all tomorrow. | |
| 02:10 | willkg left #miro-hackers | |
| 02:54 | mick_laptop left #miro-hackers | |
| 02:54 | mick_laptop joined #miro-hackers | |
| 03:00 | mattjohnson joined #miro-hackers | |
| 05:26 | z3p left #miro-hackers | |
| 05:28 | z3p joined #miro-hackers | |
| 06:45 | janetPCF joined #miro-hackers | |
| 06:51 | glee left #miro-hackers | |
| 06:51 | glee joined #miro-hackers | |
| 07:45 | z3p left #miro-hackers | |
| 07:46 | z3p joined #miro-hackers | |
| 07:47 | DGMurdockIII left #miro-hackers | |
| 08:06 | janetPCF left #miro-hackers | |
| 08:07 | CarlFK joined #miro-hackers | |
| 08:07 | janetPCF joined #miro-hackers | |
| 08:14 | janetPCF left #miro-hackers | |
| 08:20 | janetPCF joined #miro-hackers | |
| 08:39 | CarlFK1 joined #miro-hackers | |
| 08:39 | CarlFK left #miro-hackers | |
| 08:49 | janetPCF left #miro-hackers | |
| 08:59 | AndChat| joined #miro-hackers | |
| 09:00 | CarlFK1 left #miro-hackers | |
| 09:03 | CarlFK joined #miro-hackers | |
| 09:07 | CarlFK left #miro-hackers | |
| 09:38 | morganknutson left #miro-hackers | |
| 09:45 | morganknutson joined #miro-hackers | |
| 11:12 | maggie_s left #miro-hackers | |
| 11:25 | CarlFK joined #miro-hackers | |
| 11:42 | CarlFK left #miro-hackers | |
| 12:17 | arpu joined #miro-hackers | |
| 12:19 | CarlFK joined #miro-hackers | |
| 12:25 | willkg joined #miro-hackers | |
| 12:35 | z3p | good morning |
| 12:39 | willkg | morning! |
| 12:39 | hi! | |
| 12:50 | z3p | deardiary: just learned about pushurl in .git/config; hello fast pulls! |
| 12:52 | willkg | z3p: ooo... that's nice! |
| 12:52 | z3p | willkg: yeah! being able to pull via git:// is great |
| 13:00 | CarlFK left #miro-hackers | |
| 13:01 | arpu left #miro-hackers | |
| 13:02 | z3p | willkg: how are you doing on tickets? |
| 13:11 | willkg | z3p: i have two. one i'm going to work on some more after the rc. the other is kind of an umbrella ticket that i think zanoi is doing the work on, so i shoudl pass it to him. |
| 13:13 | zanoi | z3p: I have lots of stuff to do and little time. So I'm working on the UI ticket now so at least UI stuff is done for the RC |
| 13:15 | z3p | willkg: pass the UI thing to me |
| 13:15 | willkg: all my stuff is blocked | |
| 13:16 | willkg: or I can try to work on some stuff that you need done | |
| 13:23 | zanoi | willkg: which ticket are you talking about? |
| 13:24 | z3p: I'd love to push some of my stuff to you :) gimme 10 minutes though so I can get a better overview | |
| 13:27 | z3p | zanoi: sure! |
| 13:28 | willkg | bendk1: i'm +1 on "low resolution mode". that makes more sense. |
| 13:28 | z3p: i've got two tickets: http://bugzilla.pculture.org/r[…]di%40pculture.org | |
| 13:29 | z3p | willkg: and I don't have natty, so that only leaves one |
| 13:29 | willkg | zanoi: there are two natty related tickets. you took one and replied on the other. there's a third ticket that's more of an umbrella "support natty" ticket. |
| 13:29 | zanoi: it's 15444. | |
| 13:29 | z3p: right. the ffmpeg one is funky. i can't reproduce it. i haven't figured out why ffmpeg would hang. | |
| 13:30 | z3p: the ffmpeg ticket isn't a ui ticket... so i was confused. do you want me to pass that to you? if you do, i'm totally game. | |
| 13:30 | zanoi | willkg: well there's no way we'll fix ubuntu natty support for the RC |
| 13:30 | willkg | z3p: then i'll go test external drive support on windows, and start working on things i need to do for the rc. |
| 13:30 | zanoi: right. that's not what i'm talking about. | |
| 13:30 | z3p | willkg: sure; I don't have any non-blocked tickets, so I'm looking for things to work on |
| 13:31 | zanoi | z3p: would you be interested in 16995? |
| 13:32 | willkg | z3p: it's yours. :) |
| 13:32 | z3p | zanoi: sure, I can take that too |
| 13:32 | willkg | z3p: also, that ffmpeg one is an edge case. that's one of the reasons i just haven't spent a ton of time on it. |
| 13:34 | deardiary: grabbing 17266 to look at. | |
| 13:34 | z3p | willkg: I'll probably do the UI stuff first then |
| 13:34 | willkg | z3p: that's fine. |
| 13:35 | zanoi | z3p: i'll push the current code to a branch in a second |
| 13:36 | z3p | zanoi: sure |
| 13:44 | zanoi | z3p: the branch is called connect |
| 13:45 | z3p: it's good if you do the last bit because you can test on OS X as well | |
| 13:46 | I'm noticing now that it doesn't look perfect on kubuntu either though | |
| 13:50 | but that might be just another oxygen-gtk rendering error | |
| 13:54 | janetPCF joined #miro-hackers | |
| 14:39 | willkg | kcw: is there a design document or something that covers the various systems miro uses to determine media type and the heuristics involved? |
| 14:40 | kcw: i see Metadata, but that only covers the mutagen stuff. | |
| 14:45 | zanoi | z3p: I think you lost the pixel alignments in the connect screen |
| 14:46 | both the "My miro share" being vertically aligned with the checkboxes and the "Share videos" button being horizontally aligned with the togglebutton | |
| 14:49 | z3p | zanoi: looks right for me |
| 15:07 | zanoi | z3p: http://zanoi.net/pixelalignment.png |
| 15:07 | z3p: i aligned them because thats how it was in the mockup | |
| 15:08 | z3p: but maybe it's not important | |
| 15:08 | z3p | zanoi: so GTK moves some stuff around, depending on your theme; if it's like that on windows or OS X, then we can adjust |
| 15:13 | zanoi | z3p: yes the problem is on windows as well |
| 15:13 | z3p | zanoi: okay, I'll take a look |
| 15:14 | zanoi | morganknutson: ^ |
| 15:14 | z3p: you probably just need the same paddings as before | |
| 15:14 | morganknutson: is this pixel alignment important at all | |
| 15:14 | ? | |
| 15:14 | z3p | zanoi: I didn't change any of the paddings |
| 15:16 | ajonas joined #miro-hackers | |
| 15:16 | zanoi | z3p: odd. no alignments either? |
| 15:17 | z3p | zanoi: you can look at the changeset |
| 15:18 | zanoi | z3p: well it's hard to see in the first commit which part is mine, but I think you just moved code and didn't change it |
| 15:19 | z3p: btw did you check it with that error message? | |
| 15:19 | i think there waas an error message | |
| 15:19 | z3p | zanoi: yeah, it's right next to the textbox |
| 15:20 | zanoi: the way they are in the prefpanel | |
| 15:21 | zanoi | hmm..then I must have forgotten to push the pixel alignment stuff |
| 15:22 | very strange | |
| 15:22 | z3p | zanoi: oh, I didn't copy your code; I just looked at it |
| 15:23 | zanoi | z3p: oh ok |
| 15:23 | well lets see if morgan cares about it at all | |
| 15:25 | willkg | afk for a bit. need food. |
| 15:40 | z3p | afk a bit as well; I'm going for a walk to try and stretch my legs. I'll be on e-mail/gtalk if anyone needs me |
| 16:04 | bendk1 left #miro-hackers | |
| 16:04 | ajonas left #miro-hackers | |
| 16:07 | willkg | hrm... my macbook is doing much better today. |
| 16:07 | the only thing that's still not working is the spacebar. | |
| 16:08 | goodthingidon'tneedthat. | |
| 16:17 | bendk joined #miro-hackers | |
| 16:27 | willkg | bendk: i'm +1 on "low resolution mode" as opposed to "small monitor mode". |
| 16:27 | bendk | yeah, I think it makes more sense |
| 16:42 | CarlFK joined #miro-hackers | |
| 16:50 | zanoi | willkg, I have a few questions regarding how you would prefer me to implement appindicator |
| 16:50 | willkg, I guess you want to keep the systray module interface the same? | |
| 16:53 | bendk | willkg: can you take a look at http://git.pculture.org/miro/c[…]9039a9b9db96dd5a0 when you get the chance? |
| 16:54 | changed your code for finding a free directory name for torrents, I think it's fine but I want to double check | |
| 16:58 | willkg | bendk: can you guarantee that your code has the same guarantees that mkdtemp has? |
| 16:58 | bendk: if so, then that's fine. if not, then we should revert it. | |
| 16:58 | bendk | pretty sure |
| 16:58 | ajonas joined #miro-hackers | |
| 16:58 | bendk | I copied it from mkdtemp |
| 16:58 | except without the mode=700 part, which I don't think makes sense for us | |
| 17:00 | the other differience is that there's no code to give up after MAX_TRIES, but we don't have that for next_free_filename(), so I think it should be okay | |
| 17:00 | willkg | bendk: ok. |
| 17:01 | zanoi: i'm not sure what you mean by "systray module interface". | |
| 17:01 | bendk: probably best to find janetPCF's bug for the temp directory issue. | |
| 17:01 | bendk: then we can mark it as a duplicate. | |
| 17:02 | bendk | I didn't know there was one |
| 17:02 | is it assigned to jed? | |
| 17:02 | or reported by? | |
| 17:02 | willkg | pretty sure she reported it. |
| 17:03 | mmm... actually, i'll go find it. it'll be easier since it saw it the first time around. | |
| 17:03 | bendk | thanks! |
| 17:03 | zanoi | willkg, i mean if I should try to keep all the externally used methods from systray.py the same so that no other code than the one in systray.py has to be changed |
| 17:06 | willkg | bendk: http://bugzilla.pculture.org/s[…]_bug.cgi?id=16257 |
| 17:07 | zanoi: what's systray.py? | |
| 17:08 | zanoi | sorry meant lib/frontentds/widgets/gtk/trayicon.py |
| 17:08 | willkg, or where you thinking that I make a new appindicator.py | |
| 17:10 | willkg | zanoi: appindicator isn't a gtk thing--it's solely a linux platform thing. so make a new appindicator module in the linux platform code and change application.py to use either the applicator stuff or trayicon depending on what's available. |
| 17:11 | zanoi | willkg, ok, that's basically what I was going to ask :) |
| 17:11 | willkg | :) |
| 17:11 | zanoi | willkg, the other option would have been to use appindicator in trayicon.py if it's available and keep all the external usage the same to minimize risk of new bugs |
| 17:12 | willkg, but separating it probably makes it a lot cleaner | |
| 17:13 | willkg | zanoi: i'm not sure that really minimizes risk of new bugs. |
| 17:13 | but... you should feel empowered to do this as you so desire. | |
| 17:17 | z3p: i've been sitting on 16963 for a few weeks now and you go and throw something together in an hour. | |
| 17:17 | zanoi | willkg, how were you thinking regarding the behavior? Should we try to make it as similar as the old behavior as possible and in 4.1 look at making it fit better with recommended appindicator behavior? |
| 17:17 | willkg | zanoi: i have no thoughts. your instinct to make it fit in better is probably a good one. |
| 17:17 | z3p | willkg: I wrote an SSH server; I've spent more time than I care about dealing with process nonsense |
| 17:17 | willkg | z3p: ha! |
| 17:18 | zanoi | willkg, yay my instinct ftw! |
| 17:35 | CarlFK left #miro-hackers | |
| 17:44 | bendk | willkg: do you still get #17020? |
| 17:44 | the orange box ticket | |
| 17:45 | willkg | bendk: yes. |
| 17:45 | bendk | cool |
| 17:45 | willkg | bendk: i still see orange boxes. |
| 17:46 | bendk | okay, I think I have a fix, but it's not as annoying on my theme |
| 17:46 | willkg | bendk: ok. |
| 17:46 | honestly, i don't find it annoying. i was only concerned it meant bad things. | |
| 17:47 | bendk: have you added seeding stats to the item details bar, yet? | |
| 17:47 | bendk: that's probably an important thing to do today. | |
| 17:47 | bendk | that should be in |
| 18:00 | willkg | bendk: oh, so it is. thanks! |
| 18:23 | bendk | willkg: okay, just checked in the orange-box fix |
| 18:23 | tell me if it works for you | |
| 18:24 | hmm | |
| 18:24 | I'm realizing that it might not work yes | |
| 18:24 | err yet | |
| 18:25 | willkg | i can check it out now. |
| 18:25 | bendk | so I'm not sure what's going on with the way you saw it, can you test things and tell me if it's fixed? |
| 18:25 | willkg | do you remember the bug number? |
| 18:25 | pretty sure i had a list of steps to reproduce in there. | |
| 18:25 | bendk | kcw: can you peer-review this commit for me? http://git.pculture.org/miro/c[…]dbfd181ea7321607e |
| 18:25 | willkg: 17020 | |
| 18:26 | I changed some stuff in tableselection to also handle the row with keyboard focus | |
| 18:26 | s/changed/added/ | |
| 18:28 | willkg | bendk: i'm having problems reproducing the issue both before your fix and after. |
| 18:28 | bendk | cool |
| 18:28 | could you reproduce with my steps? | |
| 18:28 | willkg | i'll test with your steps. |
| 18:29 | ok. i can reproduce with your steps using the default natty theme before your fix. | |
| 18:29 | now i'll try to see if the fix fixed it. | |
| 18:31 | with your fix, i no longer see the orange box. | |
| 18:31 | there's still a grey dotted line around items like what npr mentions in comment #6. | |
| 18:33 | bendk: i tossed a comment in the bug. | |
| 18:34 | bendk, kcw: i'm looking at bug 17266. isn't it safe enough to assume that all .flv files are video? sure someone could mislabel something, but that's a pretty rare edge case. | |
| 18:35 | paroneayea left #miro-hackers | |
| 18:36 | bendk | willkg: I think so |
| 18:37 | willkg: If you could think of neat hack to fix #17269 I'd love to hear of it | |
| 18:38 | the issue is that for the resume button, we want to request 0px of space, then expand as the HBox grows, but then stop getting bigger at a certain point | |
| 18:38 | I can think of some ways of doing it, but they all require more new code then I want to add right now | |
| 18:39 | kcw | bendk: it breaks multiple selection - set_cursor replaces the existing selection |
| 18:39 | paroneayea joined #miro-hackers | |
| 18:39 | bendk | kcw: on GTK? |
| 18:39 | kcw | bendk: yeah |
| 18:39 | bendk | ouch, yes it does |
| 18:39 | okay I'll try to fix that | |
| 18:40 | willkg | bendk: i'm not sure i understand the resume button issue. is the issue the fact that the whole thing is a hotspot? |
| 18:40 | bendk: and the reason it's a hotspot is because we need to do fancy sizing? | |
| 18:41 | bendk | pretty much |
| 18:41 | the button gets packed with expand=True | |
| 18:41 | so it is taking up all the empty space, even though it's only drawing itself on part of it | |
| 18:44 | CarlFK joined #miro-hackers | |
| 18:45 | bendk | kcw: f7f615d should fix the multiple-selection issue |
| 18:45 | anyways, I'm taking a quick break, willkg: if you have a brainstorm hit me, otherwise I'll figure something out | |
| 18:46 | willkg | bendk: i don't have any good ideas short of writing a special widget that does the right thing. |
| 18:46 | z3p: ^^^ | |
| 18:47 | z3p | willkg: can you reuse the code, or at least the idea, from tv/lib/frontend/widgets/browser.py:BrowserLoadingIcon? |
| 18:47 | bendk: ^^ | |
| 18:49 | bendk | z3p: maybe let me check that out |
| 18:49 | ajonas left #miro-hackers | |
| 18:50 | bendk | yeah, that should work pretty well actuall |
| 18:54 | willkg | z3p: you rock. |
| 18:55 | kcw | bendk: it's obnoxious that GTK's get_cursor gives us a (a, b, c) path and set_cursor takes a "a:b:c" string - but I guess there's nothing we can do about that |
| 18:55 | willkg | kcw: is that a gtk problem or a pygtk bindings problem? |
| 18:58 | kcw | willkg: it must be pygtk; GTK uses Path* for both |
| 18:58 | * willkg | nods. |
| 19:06 | kcw | bendk: there's an edge case that acts funny after f7f615d: when the thing with the cursor is not selected (select two things with the keyboard; unselect the cursored thing with the mouse), switching views selects it |
| 19:06 | CarlFK left #miro-hackers | |
| 19:11 | bendk | willkg: if you follow the steps that kaz said (minus the switching views) do you get the orange box? |
| 19:12 | argh z3p you fix is too good! I want to use it to make the small resolution mode pref not needed :) | |
| 19:12 | If I would have known that I could have implemented this better | |
| 19:14 | willkg | bendk: give me a minute... i'm in the middle of something. |
| 19:14 | z3p | bendk: it looks kinda like a hack to me, but glad you're using it! |
| 19:16 | kcw | bendk: I pushed a minor change in 95ca594 that doesn't necessarily select the cursor and doesn't send any selection-changed signals while setting the cursor |
| 19:22 | bendk: also set_cursor crashes when cursor is None, like when changing views in an empty display | |
| 19:40 | willkg: maybe we should set file_type for _file_type_for_filename for any file that mutagen/mdp can't identify | |
| 19:40 | z3p left #miro-hackers | |
| 19:40 | willkg | kcw: i don't know what that means. |
| 19:41 | kcw | willkg: if we set file_type based of filename before we run mutagen or mdp, mutagen and mdp will overwrite the value whenever they can identify the file type - but if they can't it will be the value guessed from the extension |
| 19:41 | the advantage of not doing that is that theoretically files that can't be played are more likely to be marked "other" - but if that's inaccurate for FLV it might be a problem for other formats too | |
| 19:41 | willkg | so... that translates to, "if the media type that mutagen/mdp come up with is 'other', then use the file extension derived file type"? |
| 19:42 | yes? | |
| 19:43 | kcw | willkg: I don't think that's quite the same - I don't think mutagen ever marks files as "other"; when MDP marks a file as other, it would still be marked "other" - but when MDP doesn't mark a file_type it would be the fallback from the filename |
| 19:43 | janetPCF1 joined #miro-hackers | |
| 19:43 | kcw | unless MDP is always supposed to be setting a file_type |
| 19:43 | but from the current moviedata code it doesn't seem like that is the case | |
| 19:43 | willkg | ok. so a month or two ago, there was a media type related bug and i said that it's sufficiently complex and there are enough funky scenarios that we should document what's going on. |
| 19:43 | that didn't happen. | |
| 19:44 | janetPCF1 left #miro-hackers | |
| 19:44 | willkg | i haven't been involved in this enough to really trust my instincts. |
| 19:44 | so i implemented the least invasive thing i could think of. | |
| 19:44 | so... if you think your idea is great, go for it. but my advice isn't going to be useful. | |
| 19:44 | er, any advice that i have, that is. | |
| 19:45 | bendk: you've been involved in file type detection, right? does the above sound ok? ^^^ | |
| 19:45 | janetPCF1 joined #miro-hackers | |
| 19:46 | janetPCF left #miro-hackers | |
| 19:46 | AndChat| left #miro-hackers | |
| 19:47 | bendk | the change is to make it so if MDP detects the file as "other", we don't overwrite the existing type (that came from either mutagen or the extension?) |
| 19:47 | I'm not totally sure, but it seems okay to me | |
| 19:47 | kcw | the change would be that if MDP doesn't print anything matching TYPE_RE (and mutagen hasn't identified the file type), we use the extension |
| 19:47 | z3p joined #miro-hackers | |
| 19:48 | willkg | kcw: i'm confused. are you looking for a better fix for 17266? |
| 19:48 | kcw | Maybe we should not do that though: the change would reduce likelihood of marking things "other" that should not be, but it would increase the likelihood of marking things audio/video that we can't play - and we don't have solid handling of that situation at all last I checked |
| 19:49 | willkg: special-casing FLVs fixes 17266; I'm just wondering if the same situation is going to happen with formats that are not FLV | |
| 19:49 | * willkg | nods. |
| 19:49 | willkg | kcw: so... .flv has always been a problem format. the big question would be are there other problem formats. |
| 19:49 | pretty sure there aren't. | |
| 19:49 | at least, none that are as ubiquitous as .flv. | |
| 19:51 | CarlFK joined #miro-hackers | |
| 19:52 | kcw | willkg: Ok. I suppose the real fix will eventually be to fix the extractors (if we can play it it should be possible to tell it's a video) - and doing so would eliminate the cases where guessing file_type by extension would be useful |
| 19:53 | willkg | kcw: good luck with that. |
| 19:53 | plus the file_type doesn't necessarily always mean that miro can play the file. | |
| 19:54 | er, shouldn't always mean that miro can play the file. | |
| 20:03 | AndChat| joined #miro-hackers | |
| 20:11 | AndChat| left #miro-hackers | |
| 20:11 | AndChat| joined #miro-hackers | |
| 20:18 | AndChat| left #miro-hackers | |
| 20:36 | bendk | willkg: so I'm pretty much done with by bugs except for the resume button one |
| 20:36 | do you have an idea if/when we will release the RC? | |
| 20:36 | I'd like to work on things a bit tomorrow and come up with a fix that also removes small monitor mode, but if we don't have lots of time I can make a quick fix for just the resume button | |
| 20:49 | well, I'm taking of for now, I'll try to resolve the resume issue one way or another | |
| 20:50 | deardiary: most of my P1s are done, only major one left is the resume button hotspot issue | |
| 20:50 | bendk left #miro-hackers | |
| 20:54 | maggie_s joined #miro-hackers | |
| 21:10 | DGMurdockIII joined #miro-hackers | |
| 21:35 | arpu joined #miro-hackers | |
| 21:45 | maggie_s left #miro-hackers | |
| 22:37 | maggie_s joined #miro-hackers | |
| 23:32 | CarlFK1 joined #miro-hackers | |
| 23:32 | CarlFK left #miro-hackers |
