All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:40 | aude joined #miro-hackers | |
| 01:00 | DGMurdockIII left #miro-hackers | |
| 02:43 | willkg left #miro-hackers | |
| 05:45 | Odysimus joined #miro-hackers | |
| 05:47 | glee left #miro-hackers | |
| 07:52 | glee joined #miro-hackers | |
| 08:00 | glee left #miro-hackers | |
| 09:10 | aude left #miro-hackers | |
| 10:54 | janetPCF joined #miro-hackers | |
| 10:57 | janetPCF1 left #miro-hackers | |
| 10:59 | janetPCF1 joined #miro-hackers | |
| 11:02 | janetPCF left #miro-hackers | |
| 11:03 | janetPCF joined #miro-hackers | |
| 11:05 | janetPCF1 left #miro-hackers | |
| 11:13 | janetPCF left #miro-hackers | |
| 11:40 | glee joined #miro-hackers | |
| 11:41 | glee | deardiary: #17251 |
| 12:18 | Odysimus left #miro-hackers | |
| 12:19 | janetPCF joined #miro-hackers | |
| 12:30 | glee left #miro-hackers | |
| 12:32 | glee joined #miro-hackers | |
| 13:14 | willkg joined #miro-hackers | |
| 13:26 | willkg | hi! |
| 13:28 | CarlFK | morning willkg |
| 13:29 | does Miro support live streams ? | |
| 13:29 | willkg | CarlFK: no. miro doesn't do streaming formats. |
| 13:30 | CarlFK: some day, but not yet. | |
| 13:31 | CarlFK | and just to confirm, MC doesn't either (debconf-video post about streaming) |
| 13:31 | > aren't we working on a miro community setup which should be able to do exactly that? (embedded web streaming :) | |
| 13:32 | willkg | embedded web streaming. i don't even know what that means. |
| 13:33 | CarlFK | hmmm |
| 13:33 | willkg | given that you can write whatever embed code you want with MC, i think you could embed a streaming java/flash client. |
| 13:33 | but it'd be kind of weird to keep it around after the stream is done. | |
| 13:33 | CarlFK | yeah, i guess in that case it does. |
| 13:33 | ditto | |
| 13:42 | z3p | good morning #miro-hackers! |
| 13:43 | willkg | hi! |
| 13:43 | zanoi | hi! |
| 13:44 | deardiary: hoping to finish appindicator today | |
| 13:56 | willkg | z3p: if you want to spend more than 30 minutes on that, that's ok. half-a-day is probably bad. |
| 13:59 | bendk joined #miro-hackers | |
| 14:04 | z3p | willkg: I don't want to, actually |
| 14:05 | willkg | z3p: fair enough. :) |
| 14:11 | zanoi | willkg: when do you want me to go have a look at the danish/swedish/german translations? |
| 14:11 | willkg | zanoi: are all your P1 bugs done? |
| 14:12 | zanoi | willkg: no, i have the appindicator left |
| 14:12 | willkg | zanoi: then don't work on translations now. |
| 14:12 | zanoi | willkg: should i do it after finishing appindicator? |
| 14:12 | willkg | zanoi: did you get my email? |
| 14:12 | zanoi: there were two things in that email i think are relevant to this conversation. | |
| 14:12 | the first is a list of what to check when you're out of work. | |
| 14:13 | the second is a note about not asking me for work. | |
| 14:13 | i need you to get stuff done and be self-directed. | |
| 14:13 | zanoi | sure |
| 14:20 | janetPCF | hey willkg |
| 14:23 | deardiary: just checking in. Working on regression testing on osx today. | |
| 14:28 | willkg | janetPCF: hey. |
| 14:28 | janetPCF: i'm tossing around switching the build boxes to build nightlies every 2 hours. | |
| 14:28 | janetPCF: does that help you at all? | |
| 14:28 | janetPCF | so I didn't mean to completely disappear over the weekend. It was Katerina's 1st communion |
| 14:28 | willkg | janetPCF: that's really important. |
| 14:29 | janetPCF: er, 1st communion is really important. | |
| 14:29 | janetPCF | it was - and I had to scrub the bathroom and all that house-home stuff, so we could have the lunch here afterwards. |
| 14:29 | so back into things last night and today | |
| 14:30 | I don't know that builds every 2 hrs would make a huge difference. In the time I'd have to spend to do the math to see if there was something I really wanted or not, I could probably just run the script myself, since it's pretty fast and easy | |
| 14:31 | willkg | janetPCF: ok. |
| 14:31 | z3p | deardiary: touch/ed/fixed all my P1s; looking at admin p.o bugs now |
| 14:31 | bendk | glee: can I talk to you about eaeb8a24815f5 |
| 14:33 | z3p | willkg: we're planning to upgrade to webkit on Windows after 4.0, right? |
| 14:34 | janetPCF | so willkg quick question about fast resume - and checking existing files. |
| 14:34 | npr was asking if the checking happens more often than one would expect, and I spent more time looking at it today. | |
| 14:35 | I see the fastresume file gets updated frequently, but if I just shutdown / startup - seems like i get the check existing files step every time. | |
| 14:35 | not sure if I'm missing something or not. | |
| 14:37 | also - bug http://bugzilla.pculture.org/s[…]_bug.cgi?id=17383 | |
| 14:37 | the no disk in drive | |
| 14:37 | it is marked fixed, was your neighbor able to try a new build? | |
| 14:37 | z3p: a question for you too. | |
| 14:40 | ajonas joined #miro-hackers | |
| 14:40 | willkg | z3p: yes. |
| 14:41 | janetPCF: what platform are you talking about? | |
| 14:41 | janetPCF | os x |
| 14:41 | willkg | janetPCF: (taking your issues one at a time) |
| 14:41 | ok. so miro on osx has always had a long check existing files step. | |
| 14:42 | pretty sure that's a bug, but i'm not going to go look for it now. | |
| 14:42 | janetPCF | ok |
| 14:42 | willkg | janetPCF: so... on the no disk drive issue, i never heard back from my neighbor. i have no idea if that solved the problem or not. |
| 14:43 | janetPCF | I did some timings and the startup on miro 4 isn't any longer than on miro 3.5.1 |
| 14:44 | bendk | hi all, sorry I was uncommunicative this weekend. Just went through my email and accepted all the bugs that were open and I think I would be good to fix. There's 7 P1s now, shouldn't be hard to fix by tomorrow |
| 14:45 | z3p | janetPCF: yes? |
| 14:48 | janetPCF | oh - z3p thought you had already answered me |
| 14:49 | was wondering if anyone had been able to verify the no disk bug from Friday | |
| 14:49 | like if willkg 's neighbor tried a nightly or anything | |
| 14:52 | z3p | janetPCF: I do not know |
| 14:52 | janetPCF: I haven't heard from npr or holmes | |
| 14:53 | but that's also my fault; they aren't CCed on the bug | |
| 15:08 | aude joined #miro-hackers | |
| 15:09 | janetPCF | so we are up to 1000 windows downloads of RC1, 77 and 45 for os x and source respectively. |
| 15:10 | the update notification page was viewed 857 times. | |
| 15:14 | kcw | deardiary: getting my crashes done first: #17405, #17362 |
| 15:14 | willkg | janetPCF: i'm going to move the beta1 downloads so they kick up 404s now. |
| 15:15 | janetPCF: then i'm going to tweak the .htaccess file so beta1 download requests turn into rc1 download requests. | |
| 15:15 | janetPCF | cool |
| 15:16 | willkg | and then i'm going to rewrite miro in haskell or something. |
| 15:19 | CarlFK | lol |
| 15:42 | aude left #miro-hackers | |
| 16:01 | zanoi | anyone willing to help me with an appindicator usability problem? |
| 16:03 | bendk, ^ | |
| 16:05 | bendk | zanoi: what's the issue? |
| 16:06 | zanoi | miro seems to quit completely when closing the window, so as far as I understand when one wants to leave it running in the system tray one has to click on the trayicon to make the window disappear |
| 16:06 | is that correct? | |
| 16:07 | bendk | if they have the preference set |
| 16:07 | zanoi | which preference? |
| 16:07 | bendk | oh, sorry I just read your question again |
| 16:07 | when you first close miro, we pop up a dialog asking if you want to quit or just close to the tray | |
| 16:07 | this is on windows/linux I think | |
| 16:08 | then there's also a preference that you can set/unset in the general tab | |
| 16:08 | willkg | bendk: that's only on windows. on linux when you quit, or hit the x, it quits. |
| 16:08 | bendk | ahh, we still have the pref though right |
| 16:08 | ? | |
| 16:08 | willkg | bendk: clicking on the trayicon will minimize miro to the systray, though. |
| 16:08 | bendk: the pref is only on windows. | |
| 16:09 | zanoi | but the preference in the preference is only whether there should be a trayicon shown at all |
| 16:09 | *in the preference dialog | |
| 16:09 | willkg | zanoi: no. that's a different preference. |
| 16:09 | zanoi | that's what i'm saying |
| 16:09 | bendk | zanoi: so will's right I'm thinking on windows |
| 16:09 | willkg | zanoi: the one bendk is talking about is "close to tray on quit". |
| 16:09 | zanoi | ok |
| 16:10 | aude joined #miro-hackers | |
| 16:10 | zanoi | willkg, yes, my point is that the close tray on quit isn't shown in the preference dialog on linux |
| 16:10 | willkg | the "enable trayicon" is a preference on both windows and linux that shows/hides the trayicon. |
| 16:11 | yes. "close to tray on quit" is only in windows. | |
| 16:11 | bendk | so the question is why don't we have it on linux too? |
| 16:11 | zanoi | nope :) |
| 16:11 | willkg | nope what? |
| 16:11 | zanoi | so i take that as a yes to my original questions, since I'm talking about linux |
| 16:12 | the problem is that with appindicator there isn't any difference anymore between left click and right click on an item | |
| 16:12 | bendk | willkg: nope to my question |
| 16:12 | zanoi | instead it should always show a menu |
| 16:12 | willkg | zanoi: that's fine. just add a "hide to systray" item to the menu. |
| 16:12 | that's what other apps did. | |
| 16:13 | (i'm pretty sure. i know it came up a lot when the app indicator "spec" came out.) | |
| 16:13 | zanoi | but that makes it's really complicated to minimize miro to the system tray |
| 16:13 | willkg | i don't care. |
| 16:13 | this is so not worth spending 10 minutes discussing right now. | |
| 16:13 | look at what other apps do. do that. | |
| 16:13 | zanoi | no other app does it this way, that's why i'm wondering |
| 16:14 | bendk | I think just having a menu item should be fine |
| 16:14 | isn't gnome moving away from minimize anyway? | |
| 16:14 | willkg | look at what other apps do. then do that. if they don't have a "click to hide", then don't do it. |
| 16:14 | bendk | actually, I agree with will, if other apps have the menu item, then we should have one. If they don't, then just forget about it |
| 16:15 | zanoi | willkg, then I would have to add the whole "quit on windows close" behavior to windows and change the default settings for it |
| 16:15 | * willkg | sighs. |
| 16:15 | zanoi | then it would behave like other apps |
| 16:15 | willkg | fine. do that. |
| 16:15 | remember, minimal changes for 4.0. if you can't do this minimally for 4.0, then push it off to 4.0.1. | |
| 16:16 | zanoi | well miminal would be the way user unfriendly way |
| 16:16 | that's the dilemma and the reason i'm asking | |
| 16:16 | as in it would be completely different from any other app and would be quite user unfriendly, but that basically works already so i would suggest we go with it | |
| 16:17 | willkg | ok. i'm deciding for you. get the basic stuff done for 4.0 and push off the "close to tray on quit" until 4.0.1. |
| 16:17 | zanoi | you don't have to decide for me, i was asking for bens opinion :) |
| 16:17 | and yours is welcome to of course | |
| 16:18 | bendk | I'm totally lost in this |
| 16:18 | we're talking about linux-only? | |
| 16:18 | zanoi | bendk, heh |
| 16:18 | willkg | nope. i'm deciding because this is a total waste of time. do what i said. end of discussion. move on. |
| 16:18 | zanoi | bendk, yes, about the new appindicator for natty |
| 16:18 | willkg, sure | |
| 16:18 | bendk, nevermind then :) | |
| 16:21 | willkg | z3p: you just checked in a change for conversion process handling. does that handle the "No child processes" problem that we were getting when calling .wait() ? |
| 16:21 | z3p | willkg: 'handle' is a strong word |
| 16:21 | willkg | ha! |
| 16:21 | z3p | willkg: it logs the exception, but doesn't leave the conversion around |
| 16:21 | willkg | z3p: ok. does it alleviate it at all? i have 17299 in my queue and that seems like part of it. |
| 16:22 | z3p | willkg: nothing happens for the user now, at least with the 'kill the process' case |
| 16:22 | willkg: but it doesn't fix the root problem, whatever that is | |
| 16:22 | willkg | also, miro on osx isn't following songs played. the |> song indicator is totally pointing to the wrong song. |
| 16:22 | z3p: ok. that's what i wanted to know, i think. | |
| 16:22 | z3p: were you able to reproduce the issue? | |
| 16:23 | z3p | willkg: yeah, pretty trivially; start a bunch of conversions for a device sync, then cancel it |
| 16:23 | willkg | z3p: that rocks. thank you so much! |
| 16:23 | z3p | willkg: one of them succeeds, the other seem to get 'no child procceses' |
| 16:23 | *others | |
| 16:23 | it'll probably happen if you start a bunch of conversions normally, then 'cancel all' | |
| 16:24 | willkg | i need to grab food. afk a bit. |
| 16:26 | kcw: where are you at? | |
| 16:30 | z3p: would you hate me if i asked you to look at the bubble indicator bug that none of us want to work on? | |
| 16:30 | z3p | willkg: ah, yeah; you should be able to do the same 'fix' for part 1 of 17299 |
| 16:30 | willkg: already took it :) | |
| 16:30 | willkg | z3p: oh, hot shit. you just grabbed it. you rock! |
| 16:31 | z3p: when you're done cycling through stuff, get kcw to pass bugs to you. he's got way too many on his plate and we've blocked on him for the last two releases now. | |
| 16:31 | kcw | willkg: I think my 2 crash bugs (17405, 17362) will take most of the day. Then I have the OS X loses scroll pos bug (17153). I have a bunch of other P1s but the rest are all either very small or of normal or lower severity - there's definitiely no way I can do all of them within this timeframe, so I'm going to move the normal-or-below bugs to 4.0.1 right now and comment on each that if it's more vital severity should be increased. |
| 16:32 | z3p | kcw: assign them to me, or to admin |
| 16:32 | kcw | gotcha |
| 16:32 | willkg | kcw: yeah. don't push stuff off to 4.0.1 just because you can't get it done. stuff should get pushed off to 4.0.1 because it's not critical to get it done for 4.0. |
| 16:33 | kcw: and when you shed bugs, make sure to do a brain dump of whatever you know about it in the bug comments. | |
| 16:33 | kcw | sure |
| 16:35 | willkg | ok. afk for food for real this time. |
| 16:57 | DGMurdockIII joined #miro-hackers | |
| 17:06 | janetPCF left #miro-hackers | |
| 17:07 | janetPCF joined #miro-hackers | |
| 17:07 | kcw | deardiary: my bug list feels managable now |
| 17:25 | z3p | afk for a bit...lunch |
| 17:34 | janetPCF1 joined #miro-hackers | |
| 17:35 | janetPCF left #miro-hackers | |
| 17:55 | janetPCF1 left #miro-hackers | |
| 17:56 | janetPCF joined #miro-hackers | |
| 17:57 | z3p | deardiary: back in saddle on #17035 |
| 18:00 | janetPCF left #miro-hackers | |
| 18:04 | Odysimus joined #miro-hackers | |
| 18:08 | janetPCF joined #miro-hackers | |
| 18:17 | willkg | bendk: where are you at? how're you doing on the bugs in your queue? |
| 18:19 | bendk | I'm working on #17373 |
| 18:19 | I think I have a fix for it actually, which is surprising | |
| 18:19 | I'm also working through a bunch of smaller bugs, my queue seems pretty okay right now | |
| 18:19 | there's 1 more part of the 800x600 bug that I want to fix | |
| 18:20 | which is just hiding the audio/video buttons for the all feeds tab | |
| 18:21 | * willkg | nods. |
| 18:22 | willkg | bendk: can you wait on that one until you get the others worked out? |
| 18:22 | bendk | okay, sure |
| 18:23 | willkg | bendk: 17398 looks scary. 17410 and 17393 are also bad. |
| 18:23 | bendk: do you think 17328 is related to 17373? | |
| 18:23 | bendk | oops |
| 18:23 | I meant 17398 when said 17373 | |
| 18:23 | I just handed npr a build to test out that might have a fix | |
| 18:24 | willkg | awesome. |
| 18:24 | 17373 is scary, too. | |
| 18:24 | all these bugs are scary. | |
| 18:24 | some day, someone is going to make a slasher film with these bugs. it's going to scare the bejesus out of people. | |
| 18:25 | bendk | so for 17373 all I'm going to do is to add a loading indicator when we're importing media |
| 18:25 | willkg | ok. |
| 18:25 | bendk | I think itunes and other media players have similar issues, they just have a dialog box which makes things more obvious |
| 18:25 | willkg | you don't have to go through updates for all of those bugs. i just want to make sure they're in your known queue. |
| 18:25 | bendk | sure |
| 18:26 | paulproteus | deardiary: Comtemplating canonical URL redirection + usability + google juice. See my recent post to miro-community-development. |
| 18:26 | bendk | janetPCF: you on? |
| 18:26 | janetPCF | yes bendk |
| 18:27 | bendk | what's the URL for " Same url Feed 1"? |
| 18:27 | or what's the best way to get to it, I forget the testing guide URL | |
| 18:27 | janetPCF | hold on |
| 18:28 | bendk | janetPCF: I got it |
| 18:28 | nevermind | |
| 18:28 | janetPCF | http://pculture.org/feeds_test/same-url-feed2.rss |
| 18:29 | here is the test case the bug came from: http://litmus.pculture.org/show_test.cgi?id=189 | |
| 18:37 | z3p | ugh |
| 18:37 | bendk | janetPCF: for the torrent folder migration bug, do you know if the torrents were downloaded during the same miro session or a previous one? |
| 18:38 | janetPCF | I'm going to guess that it was multiple sessions as I'm usually doing others tests that require startup / shutdown |
| 18:39 | today on osx I downloaded some torrents / containers. So I can migrate now, knowing 100% for sure that it was on multiple sessions | |
| 18:46 | bendk | I just checked |
| 18:46 | it looks like it's only previous sessions | |
| 18:46 | we should split that test into 2 because it's two different codepaths | |
| 18:52 | janetPCF | oh see, now I'm confused? |
| 18:52 | bendk: are you talking about the container torrents or the feed expiration? | |
| 18:52 | bendk | torrent migration in general |
| 18:52 | janetPCF | ok |
| 19:05 | willkg | z3p: when you have a moment, can you take a look at 2d2ac36c and ac829e0 and peer review them? |
| 19:05 | z3p: i spent an hour testing them on Windows, OSX and Linux and going back and forth between the pages and the different combinations of things. | |
| 19:06 | z3p: the code is kind of hacky in some places, but i tried to document those bits. | |
| 19:07 | z3p | willkg: sure |
| 19:17 | deardiary: I'm sorry about 53c5a98 | |
| 19:18 | * willkg | smirks at z3p. |
| 19:19 | willkg | deardiary: landed first time dialog search pane overhaul. re-running osx nightly to pick up the changes. |
| 19:19 | z3p | I've got a notebook page full of math where I tried to figure out what was happening |
| 19:20 | willkg | deardiary: first a small break, then on to conversion process problems. |
| 19:27 | kcw | deardiary: one crash down, one to go; a little ahead of my expected timing |
| 19:30 | bendk | willkg: when you get back can you review this one: |
| 19:30 | http://git.pculture.org/miro/c[…]59e5f546fc10a5aa9 | |
| 19:30 | willkg | as a side note, i hate torrents now. |
| 19:31 | bendk: ahh... that looks a lot like a few other issues i fixed. this is all from glee's changes in november. | |
| 19:31 | we should rename next_free_filename to i_will_make_your_life_miserable. | |
| 19:31 | it's more correct a name. | |
| 19:32 | bendk | heh |
| 19:32 | yeah, this isn't the first change I've had to make either | |
| 19:34 | willkg | bendk: i tend to like positive checks over negative ones because they're easier to think through. so i would have done "if fileutil.isdir(filename): ..." instead of "if not fileutil.isdir(filename): ..."</nit> |
| 19:35 | bendk | yeah, I agree |
| 19:35 | I'll change that now, I'm not sure what I was thinking there | |
| 19:36 | willkg | is migrate_file actually moving the directory tree? |
| 19:36 | er, fileutil.migrate_file ? | |
| 19:36 | the code changes look ok to me. | |
| 19:36 | fileutil should get re-written. pretty sure half of that's from the u3 days. | |
| 19:36 | some day i'm going to rip the u3 code out. | |
| 19:37 | bendk | yes |
| 19:37 | willkg | by "rewritten" i mean "fixed so that it doesn't look like it evolved from worms at the bottom of the ocean". |
| 19:37 | bendk | Althought I should check one thing, if the filename is already there, it might not be able to do a rename and have to copy, then delete instead |
| 19:41 | janetPCF | willkg: you think it would be worth trying to get Dean or Holmes to blog about translations to the Unisubs community - seems like that should be a good multi-lingual group. |
| 19:41 | bendk | nice, the rename does work |
| 19:41 | willkg | janetPCF: i have no idea. |
| 19:42 | janetPCF | I'll ask |
| 19:42 | willkg | janetPCF: but it definitely can't hurt. |
| 19:42 | janetPCF | can't ur |
| 19:42 | hurt | |
| 19:45 | willkg | kcw: that change you just made for bug 17411 can't be right. |
| 19:46 | kcw: according to that change, if there's no album_artist (whatever the hell that is), then it sorts by artist. | |
| 19:46 | kcw: that's exactly the problem i reported: sort by artist and sort by album are the same. | |
| 19:46 | kcw: are you able to reproduce the problem i'm having? are you testing this? | |
| 19:47 | kcw | willkg: as discussed in the bug, my implementation of 17355 was not correct. Now it is correct. Whether the sort change in 17355 is desirable is a separate question. |
| 19:48 | willkg | kcw: bug 17411 is explicitly a problem i reported where sorting by artist and sorting by album are the same. |
| 19:48 | kcw: you've made two changes that seem to have nothing to do with that problem. | |
| 19:48 | kcw: so... i don't know what you're working on, but it's not my problem and my problem is definitely bad behavior. | |
| 19:49 | kcw: sorting with the artist column and the album column shouldn't yield the same exact sort. that can't possibly be right. | |
| 19:49 | kcw | willkg: it's the problem you described in #c3. It sounds like your problem to me. In #c2 I addressed the behavior problem. |
| 19:50 | willkg | kcw: i don't think you understand what i'm seeing. |
| 19:50 | kcw: if you did, you souldn't be saying that it's correct. | |
| 19:51 | beyond that, i find this conversation totally puzzling. | |
| 19:51 | kcw | willkg: as I have said, I do not like the behavior, but I believe I have implemented what was requested in #17355. |
| 19:51 | in #17355#c2 and #17355#c4 | |
| 19:51 | * willkg | sighs. |
| 19:53 | janetPCF | bendk: I marked bug #17410 invalid after a retest and it worked fine. |
| 19:54 | since that items gets reused in a bunch of tests, maybe some leftovers? | |
| 19:54 | sorry for the time-waster | |
| 20:01 | zanoi | appindicator is ready for testing, it's in branch appindicator |
| 20:01 | would be great if someone could have a look at it | |
| 20:06 | janetPCF | deardiary: rerunning the nightly on osx so I can check out the migration |
| 20:15 | zanoi | janetPCF, you have natty working with unity right? |
| 20:15 | DGMurdockIII left #miro-hackers | |
| 20:16 | janetPCF | I have an install of Natty - but I haven't installed anything on it yet |
| 20:16 | zanoi | janetPCF, not even miro? |
| 20:17 | janetPCF | no - it's on the machine I hate, so I installed it, but then put it to the side |
| 20:17 | not a big deal to get miro on it, just don't have natty at the top of my priority list. | |
| 20:17 | zanoi | janetPCF, when the appindicator stuff lands it really needs a lot of testing :/ |
| 20:17 | and that only can be done on natty | |
| 20:18 | janetPCF | ok |
| 20:18 | willkg | janetPCF, zanoi: if we don't get that tested for 4.0, we can push it off to 4.0.1. |
| 20:18 | zanoi | willkg, yes, but it is done now |
| 20:18 | willkg | zanoi: yes, but if we can't get it tested for 4.0, we can push it off to 4.0.1. |
| 20:19 | zanoi | yes of course |
| 20:27 | CarlFK left #miro-hackers | |
| 20:28 | willkg | z3p: the .wait() is explicitly to deal with the process shutting down, right? |
| 20:42 | z3p: you on? | |
| 20:53 | mmm... i think the answer is, yes. so i'll go with that for now. | |
| 21:07 | CarlFK joined #miro-hackers | |
| 21:16 | ajonas left #miro-hackers | |
| 21:28 | z3p | willkg: yes, it is |
| 21:29 | willkg: as I understand it, .wait() does the cleanup for the process being done, however that happened | |
| 21:29 | willkg | z3p: so at the point where miro is calling wait(), that process is "done". |
| 21:29 | ok. good to know. | |
| 21:29 | so then it seems like the exception handling that's there already (around line 840 in conversions.py) is ok. | |
| 21:30 | z3p | willkg: yes, but we need to set self.error so that is_failed() knows we're finished |
| 21:31 | willkg | z3p: but this isn't really a failure case. |
| 21:31 | z3p | willkg: I'm not 100% sure that process_handle.returncode is getting set to something that is_failed() knows about |
| 21:31 | willkg | hrm.... |
| 21:31 | z3p | willkg: that might be useful to see |
| 21:31 | willkg | mmm... possibly. |
| 21:32 | so 17299 is when holmes cancels the conversion. it's not a failure case. | |
| 21:32 | so maybe the existing code is right. | |
| 21:34 | i'm not sure what i said in comment #17 is right. | |
| 21:35 | z3p | willkg: yes, #1 looks like it's a different problem, but the process is going through the 'normal' flow |
| 21:35 | aka not getting killed | |
| 21:35 | s/but/where/ | |
| 21:36 | willkg | i also can't reproduce the problem. when i hit the X, the conversion cancels immediately for me. |
| 21:42 | maggie_s joined #miro-hackers | |
| 21:44 | willkg | z3p: ok... i think i see what's going on. |
| 21:45 | z3p: when he's clicking on "cancel", there's no conversion with that key at the time. | |
| 21:47 | hrm... let me think about this a little more. | |
| 21:52 | bendk | z3p: can you peer-review this changeset? |
| 21:52 | http://git.pculture.org/miro/c[…]dd85a3ac65304c66d | |
| 21:52 | I think you did recent work with the loading icons | |
| 21:54 | willkg | z3p: the is_failed code looks at the process_handle.returncode already. |
| 21:55 | z3p | willkg: I know, but I don't know if .wait() sets it to something if it throws an exception |
| 21:55 | bendk: the onloy think to check is that the all the tab renderers actually do something with 'updating_frame' | |
| 21:55 | willkg | z3p: well, so this isn't a failure case and it looks like holmes presses the big X on the task and the cancel code looks up the task and it doesn't exist and thus we're in a weird state where the task shows up in the ui, but it doesn't exist anymore. |
| 21:56 | z3p: since it's not showing up in a failed state, i don't think the .wait() is affecting the returncode. | |
| 21:56 | bendk | z3p: cool thanks. I tested it and I saw the loading icon for both the audio and video tabs, so I think we're good |
| 21:57 | z3p | willkg: so I tried this out this morning, and canceling the conversions with the 'X' in the device sync killed everything enough that miro closed |
| 21:57 | willkg | z3p: wait... what? |
| 21:57 | z3p: i'm not doing device sync conversions. i've been doing "regular" conversions. are device sync conversions different in some way? | |
| 21:57 | z3p | willkg: what other thing are you seeing? |
| 21:57 | willkg | z3p: i can't reproduce this issue at all. i'm just going by what i see in holmes' logs. |
| 21:58 | z3p: maybe i should pass this to you if you think it's device-related? | |
| 21:58 | z3p | willkg: ah, I read big 'X' and thought that he was doing device syncing |
| 21:58 | willkg | z3p: he is. he's syncing to his phone. |
| 21:59 | z3p | willkg: oh, then it's fixed |
| 21:59 | willkg | z3p: but i haven't done a device sync in ages, so maybe i'm doing this wrong. |
| 21:59 | z3p | willkg: I thought this was some other issue |
| 21:59 | willkg | z3p: can you look through the bug and double check that? |
| 21:59 | z3p: it's 17299. | |
| 21:59 | z3p: he says "slow response", but what's really going on is that the ui isn't showing what's going on. | |
| 22:00 | morgan joined #miro-hackers | |
| 22:00 | z3p | willkg: also he's calling the device tab the converting tab; it's confusing |
| 22:01 | willkg: I'm confident that #17299 is fixed | |
| 22:02 | janetPCF left #miro-hackers | |
| 22:04 | z3p | willkg: I'm not confident that we've fixed whatever other process issue is there, but we can deal with that later |
| 22:04 | willkg: it'll throw exceptions into the log, but that should be it | |
| 22:05 | willkg | z3p: cool. ok, i'm going to mark this as "paul thinks this is fixed". |
| 22:05 | z3p | willkg: sounds good; you should probably switch it to a device bug anyways |
| 22:05 | willkg | done. |
| 22:05 | z3p: thank you! | |
| 22:06 | deardiary: shirked off 17299. now going to look into 17397 to see what the deal is. | |
| 22:18 | zanoi | should I push appindicator to master now, so that it gets proper testing? |
| 22:21 | bendk | willkg: kcw: can you peer-review this change? |
| 22:21 | http://git.pculture.org/miro/c[…]cdca7b288eb9eaeba | |
| 22:22 | willkg | bendk: did you check to see why it was in an as_idle? |
| 22:22 | bendk | it was a large change by kaz, I'm guessing it was made as_idle to match update_finished() |
| 22:22 | but as far as I can tell it's not needed for update_skipped() | |
| 22:26 | willkg | i'm testing the change out now. |
| 22:26 | bendk: in the logs, i see a lot of "WARNING root: Don't know how to handle metadata progress for (u'device', '/dev/sdb1-audio')" | |
| 22:26 | bendk: is that from the progress update changes you did earlier? | |
| 22:26 | bendk | yes |
| 22:26 | I guess that shouldn't be a warning | |
| 22:26 | I forgot about device items | |
| 22:27 | or maybe we should show loading indicators for them too | |
| 22:27 | willkg | it has an import indicator already. |
| 22:27 | it's the cylon progress throbber thingy. | |
| 22:27 | * willkg | likes the cylon progress thingy. |
| 22:27 | bendk | I mean on the device tab |
| 22:27 | but I don't think it's as important as the library tabs | |
| 22:27 | willkg | on the tab itself? |
| 22:27 | i don't know. doesn't bother me either way. | |
| 22:27 | bendk | I'm just going to remove the warnings for now |
| 22:28 | willkg | ok. |
| 22:28 | that'll nix a lot of logging processing. ;) | |
| 22:28 | z3p | bendk: I thought about that too |
| 22:28 | bendk: I think there's even a bug | |
| 22:29 | bendk: but for OS X, that means you couldn't drag anything to the device for the whole time it's loading | |
| 22:29 | bendk | ahh |
| 22:29 | I think it's much less important for a device | |
| 22:29 | z3p | bendk: I agree, so I punted the bug to later |
| 22:31 | glee left #miro-hackers | |
| 22:33 | aude left #miro-hackers | |
| 22:36 | willkg | bendk: takes about 11 minutes to deal with my massive external drive and all the crap on it. |
| 22:37 | bendk: but i think your change looks fine to me. | |
| 22:37 | bendk | willkg: thanks |
| 22:41 | kcw | bendk: 1ddcb22 should be fine. I don't think there's any reason that ought to be as_idle. |
| 22:46 | bendk | kcw: cool, thanks |
| 22:46 | okay, most of my P1s are done | |
| 22:46 | taking of for today | |
| 22:47 | bendk left #miro-hackers | |
| 23:03 | zanoi | willkg, is there a reason why there is no first run dialog showing after deleting the config directory? |
| 23:09 | kcw | zanoi: do you mean your gconf config directory? |
| 23:16 | zanoi | kcw, i meant the .miro directroy. Did I miss until now that the wizard is windows only? |
| 23:17 | kcw | I don't know if we use gconf on windows too. I'd think we would. |
| 23:17 | anyway, when I run "gconftool-2 --recursive-unset /apps/miro", I get the first time dialog. Is that not working for you? | |
| 23:17 | * zanoi | is confused |
| 23:17 | zanoi | it didn't earlier |
| 23:17 | i'll try again | |
| 23:18 | kcw | well if it's flaky, that's certainly bad |
| 23:19 | zanoi | kcw, ah now it works. sorry about that |
| 23:19 | kcw | zanoi: maybe you didn't delete .miro? I think if you don't delete both at once it doesn't trigger the first-time dialog |
| 23:20 | zanoi | kcw, i probably just entered the wrong gconf path, and most of the time i tried deleting .miro cause i thought that's where it was saved |
| 23:20 | kcw, anyway. thx, problem solved. | |
| 23:20 | deardiary: appindicator is finished | |
| 23:21 | deardiary: had a long list of possible bugs I had to reproduce. Luckily only one turned out to be reproducible | |
| 23:22 | deardiary: kubuntu rendering error now has a bug in kde, so I'll defer it until i hear something from them | |
| 23:24 | aude joined #miro-hackers |