All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:01 | uwe_ left #miro-hackers | |
| 00:02 | uwe_ joined #miro-hackers | |
| 00:04 | Stefan_ left #miro-hackers | |
| 00:47 | kcw joined #miro-hackers | |
| 01:38 | willkg left #miro-hackers | |
| 02:26 | mattjohnson left #miro-hackers | |
| 04:12 | kcw_ joined #miro-hackers | |
| 04:15 | kcw left #miro-hackers | |
| 04:51 | kcw_ left #miro-hackers | |
| 05:09 | Oraby | Hello guys, I've just tried my luck with one of the bitesized bugs and I've fixed it. I got couple of questions: 1. Given that the bug I worked on was something that had to do with the uninstaller, how to provide a test case for it other than: "The behavior was there, and now it is not there".. |
| 05:25 | Also when proposing a patch, how do I point out the parts that were diffed (given that its a .nsi file with over 1000 LOC)?? Should I just mentioned where the changes were made in the bug-comment?? | |
| 07:15 | janetPCF joined #miro-hackers | |
| 07:25 | janetPCF left #miro-hackers | |
| 10:30 | maggie_s left #miro-hackers | |
| 11:46 | willkg joined #miro-hackers | |
| 11:54 | glee1 left #miro-hackers | |
| 11:55 | glee joined #miro-hackers | |
| 11:55 | glee left #miro-hackers | |
| 11:56 | glee joined #miro-hackers | |
| 12:29 | willkg | hi! |
| 12:35 | ajonas joined #miro-hackers | |
| 13:00 | ajonas left #miro-hackers | |
| 13:05 | Stefan_ joined #miro-hackers | |
| 13:46 | janetPCF joined #miro-hackers | |
| 13:52 | mattjohnson joined #miro-hackers | |
| 13:52 | ajonas joined #miro-hackers | |
| 14:55 | kcw joined #miro-hackers | |
| 15:19 | ajonas left #miro-hackers | |
| 15:25 | Stefan_ left #miro-hackers | |
| 15:48 | kcw left #miro-hackers | |
| 15:48 | kcw joined #miro-hackers | |
| 15:53 | ajonas joined #miro-hackers | |
| 16:14 | willkg | bendk: i created a Miro-4.0.1 branch based on the v4.0.1 tag. |
| 16:15 | bendk | cool, thanks |
| 16:16 | zanoi | one thing I forgot to ask in the call, is what milestone should most bugs be reported to now? |
| 16:16 | do we report them as 4.1 and then ask ben if it can be changed to a point release? | |
| 16:16 | or the other way around? | |
| 16:18 | janetPCF left #miro-hackers | |
| 16:18 | janetPCF joined #miro-hackers | |
| 16:30 | willkg | zanoi: so... i think you're asking "what milestone should we assign bugs to to get fixed". |
| 16:30 | zanoi: if you're planning to put it on your plate, assign it to whatever milestone you think makes sense. | |
| 16:30 | zanoi: if you're not planning to put it on your plate, don't assign a milestone. | |
| 16:32 | zanoi | willkg, ok. So its fine if I assign stuff to point releases without asking the release person for the point release whether it's ok that it goes in right? |
| 16:47 | bendk | wow |
| 16:47 | so I already fixed the preparing items bug | |
| 16:47 | #16383 | |
| 16:55 | willkg | zanoi: use your best judgement. |
| 16:55 | zanoi | ok |
| 17:06 | leenzada joined #miro-hackers | |
| 17:07 | ajonas | hi leenzada |
| 17:13 | willkg | bendk: sorry about that. i forgot to skim through the subprocess branch. i'll do that now. |
| 17:13 | bendk | no problem |
| 17:14 | Dawnrell joined #miro-hackers | |
| 17:15 | bendk | z3p: can I ask you about a changeset from march? |
| 17:15 | 595cc4c2e49a8a4bb351e710968ed19696aa0e30 | |
| 17:15 | z3p | bendk: sure, let me pull it up |
| 17:15 | bendk | hmm, actually maybe not |
| 17:16 | you just changed the line there, I was wondering why we need to do anything with the icon before calling the first-time handler | |
| 17:17 | z3p | bendk: my guess is because otherwise the first time handler won't show the miro icon |
| 17:17 | bendk | yeah, except it seems to work fine for me when I comment it out |
| 17:17 | plus that bug we talked about on the call gets fixed | |
| 17:18 | z3p | wow |
| 17:19 | bendk | I think on windows the icons are built into the .exe right? |
| 17:19 | in any case, could you possibly see something going very wrong if we removed that line? | |
| 17:20 | I think the issue is that if the database upgrade dialog is still open, somehow that call blocks, and then we're deadlocked | |
| 17:26 | z3p | bendk: go for it |
| 17:27 | bendk | cool |
| 17:29 | willkg: so I think I have a fix for #17593, I'm going to build a nightly on the windows box to give to people to test | |
| 17:30 | I ended up going with a different, but still pretty trivial change to fix things | |
| 17:30 | http://git.pculture.org/miro/commit/?h=Miro-4.0.1 | |
| 17:30 | does that make sense to you? | |
| 17:31 | willkg | bendk: huh. i'm not sure what _get_icon_location is. give me a minute. |
| 17:31 | bendk | it gets the path to the icon for the window and also sets it as the default icon for new windows |
| 17:31 | as far as I can tell, even without it the icons are still correct | |
| 17:32 | willkg | weird. |
| 17:33 | it gets called already in _run in WindowsApplication. | |
| 17:33 | so, i think that looks ok to me. | |
| 17:34 | i still think we should save preferences after changing the first time preference. | |
| 17:35 | bendk | seems good to me |
| 17:35 | I'll make that change too | |
| 17:35 | willkg | though, i don't remember offhand why i thought that was a good idea earlier. |
| 17:35 | but i had some serious conviction about it, so it must have been a really great idea. | |
| 17:36 | </kidding> | |
| 17:40 | Dawnrell left #miro-hackers | |
| 17:42 | bendk | kcw: I'm really confused as to how a parent can have a larger height than a child.. It seems like it only depends on the "tall" attribute and that's just set statically in the TabInfo class |
| 17:45 | kcw | bendk: I don't know - z3p implemented #16559 |
| 17:46 | bendk | heh, he sent me an email too |
| 17:46 | z3p: can you explain it? | |
| 17:47 | z3p | bendk: kcw: all the top level tabs are TALL |
| 17:47 | bendk: kcw: but the podcasts/other children are not | |
| 17:47 | natea joined #miro-hackers | |
| 17:47 | bendk | z3p: but how does that happen? where do we set tall? |
| 17:47 | z3p | bendk: tablist.py:TabInfo |
| 17:49 | bendk | so child tabs don't use TabInfo? |
| 17:49 | z3p | bendk: no; child tabs use GuideInfo, or FeedInfo |
| 17:50 | or PlaylistInfo | |
| 17:50 | bendk | ahh that's right |
| 17:50 | okay, my fixed_size change is going away :) | |
| 17:50 | sorry for all the confusion on this one | |
| 17:54 | willkg: I just checked in the change for to save the config after we set STARTUP_TASKS_DONE | |
| 17:54 | I'm going to build a windows build and ask users to see if it fixes things for them | |
| 17:54 | then I guess we let it bake for a day or so and release it as 4.0.2 | |
| 17:55 | willkg | 4.0.2 or 4.0.1.1? |
| 17:56 | as a side note, when we did 0.9.9.9, i think we had problems on windows because some code couldn't handle versions with 3 dots. so... hopefully we either fixed that or rewrote it in the last 4 years. | |
| 17:57 | bendk | sory 4.0.1.1 |
| 17:59 | willkg: do I need to change anything in the appcast before I give it to people to test? | |
| 18:10 | okay, testing build is out the door, I'm taking a lunch break | |
| 18:21 | willkg | bendk: i'm not sure... i should have checked that. |
| 18:21 | bendk: and by "appcast", i think you mean "app.config". | |
| 18:22 | bendk | willkg: yeah, I meant app.config |
| 18:22 | DGMurdockIII joined #miro-hackers | |
| 18:22 | bendk | I think it's okay for the testing build, maybe I should have changed the version number, but I think it should be fine |
| 18:23 | willkg | bendk: it'll look like 4.0.1. someone using it won't be able to tell the difference. i'll tweak it and throw a new nightly out. |
| 18:23 | bendk: where'd you put the current nightly? | |
| 18:23 | bendk | http://nightlies.pculture.org/[…]17593-testing.exe |
| 18:23 | thanks for that | |
| 18:23 | willkg | ok. |
| 18:24 | bendk | okay, taking of for real now. be back in a short while |
| 18:24 | willkg | ok. |
| 18:45 | bendk: fixed the app.config file, and rebuilt the build and put it where you put it. | |
| 19:05 | ajonas | paulproteus , z3p : i think youtube shortener doesn't work on dev, but it does seem different from before so i think i'll just reopen |
| 19:05 | paulproteus | It doesn't work in some new, intriguing way (?). (-: |
| 19:05 | ajonas | willkg, others: question about miro on ubuntu in #miro |
| 19:08 | paulproteus: yes | |
| 19:08 | Chillance joined #miro-hackers | |
| 19:09 | Chillance | have anyone here experienced Miro hanging and locking the HD up (Ubuntu) after just a few seconds from startup? |
| 19:18 | willkg | where "HD" is hard drive? |
| 19:18 | which version of ubuntu and which version of miro? | |
| 19:19 | Chillance: ^^^ | |
| 19:19 | Chillance | well |
| 19:19 | seems it actually might be a hd failure thing | |
| 19:20 | willkg | oh, that totally sucks. |
| 19:20 | Chillance | yea, but important stuff on it backed up |
| 19:20 | sucks anyway still though | |
| 19:21 | * paulproteus | and Chillance are talking it out in #miro |
| 20:10 | CarlFK | willkg: you should prolly disable comments in pmc. the daily spam is kinda depressing. |
| 20:10 | unless you want to leave it on, then I will tough it out ;) | |
| 20:11 | willkg | CarlFK: once in a blue moon, someone leaves a comment that indicates a problem with the video. so... i'm inclined to leave it if only for that reason. |
| 20:11 | CarlFK | k |
| 20:11 | willkg | CarlFK: however, i don't think any of the comments have been useful and my email address is on every page. so i'm game for removing it. it's definitely less maintenance. |
| 20:12 | CarlFK: oh... looks like there's no way to disable comments. i think we'd have to do it in the templates. | |
| 20:13 | ajonas: does that sound right? is there a way to disable comments altogether in MC? | |
| 20:13 | ajonas | willkg: yes, other than cutting it out of the theme |
| 20:13 | willkg: do you already limit to registered users? | |
| 20:13 | willkg | ajonas: no. but all comments are moderated. so nothing shows up unless i accidentally approve it. |
| 20:14 | ajonas | willkg: if you limit it to registered users that would probably cut most of the spam |
| 20:14 | * willkg | nods. |
| 20:14 | CarlFK | works for me |
| 20:16 | willkg | ok. done. |
| 20:32 | bah. forgot to blog the notes. here they are now: http://bluesock.org/~willg/blo[…]all_20110601.html | |
| 21:18 | SNAILBot left #miro-hackers | |
| 21:19 | SNAILBot joined #miro-hackers | |
| 21:19 | Topic for #miro-hackers is now Miro and MiroCommunity.org developers channel -- Got a bug? Have the ticket number ready. Nightlies at http://nightlies.pculture.org/ . | Channel is logged, "/msg SNAILBot help" for more info. | |
| 21:26 | Odysimus left #miro-hackers | |
| 21:31 | Odysimus joined #miro-hackers | |
| 21:52 | DGMurdockIII left #miro-hackers | |
| 22:08 | ajonas | paulproteus: "Create a new video source on any MC site" - we can't use an existing source? |
| 22:08 | oh wait nm | |
| 22:08 | misread | |
| 22:09 | paulproteus: "Find some long category on a MC" - does it only work with categories? or all mc feeds? | |
| 22:22 | leenzada left #miro-hackers | |
| 22:23 | paulproteus | ajonas: It works with all MC feeds, or at least it should. |
| 22:23 | ajonas | paulproteus: excellent |
| 22:23 | paulproteus | I think initially we created the ticket with categories in mind, but should work for all of 'em, yeah. |
| 22:35 | ajonas | paulproteus: it's important that it's all of them, sorry if i wasn't clear on that, i will make sure to test |
| 22:37 | paulproteus | Cool. Well, I implemented it for all of them, so that should work out fine. |
| 22:37 | (unless I failed to implement it properly, in which case I'll write a bunch more automated tests.) | |
| 22:37 | Night, all! | |
| 23:04 | ajonas left #miro-hackers | |
| 23:26 | maggie_s joined #miro-hackers | |
| 23:27 | Dawnrell joined #miro-hackers | |
| 23:37 | willkg left #miro-hackers |