All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:04 | willkg left #miro-hackers | |
| 00:45 | janet1 left #miro-hackers | |
| 00:49 | Odysimus left #miro-hackers | |
| 01:29 | Odysimus joined #miro-hackers | |
| 02:41 | CarlFK left #miro-hackers | |
| 03:48 | CarlFK joined #miro-hackers | |
| 03:56 | kcw left #miro-hackers | |
| 04:02 | kcw joined #miro-hackers | |
| 04:06 | kcw left #miro-hackers | |
| 05:28 | Oraby joined #miro-hackers | |
| 05:28 | maggie_s left #miro-hackers | |
| 07:16 | natea left #miro-hackers | |
| 07:25 | janet joined #miro-hackers | |
| 07:43 | natea joined #miro-hackers | |
| 07:46 | maggie_s joined #miro-hackers | |
| 07:50 | natea left #miro-hackers | |
| 08:19 | janet left #miro-hackers | |
| 08:40 | natea joined #miro-hackers | |
| 09:27 | natea left #miro-hackers | |
| 11:52 | natea joined #miro-hackers | |
| 12:04 | maggie_s left #miro-hackers | |
| 12:27 | Jarrhead joined #miro-hackers | |
| 12:42 | Jarrhead left #miro-hackers | |
| 12:55 | Jarrhead joined #miro-hackers | |
| 13:06 | janetPCF joined #miro-hackers | |
| 13:10 | natea left #miro-hackers | |
| 13:12 | natea joined #miro-hackers | |
| 13:28 | natea left #miro-hackers | |
| 13:44 | willkg joined #miro-hackers | |
| 13:55 | willkg | hi! |
| 13:57 | ajonas joined #miro-hackers | |
| 13:57 | paulproteus | Morning, ajonas. |
| 14:23 | ajonas left #miro-hackers | |
| 14:28 | ajonas joined #miro-hackers | |
| 14:37 | ajonas left #miro-hackers | |
| 14:41 | ajonas joined #miro-hackers | |
| 14:42 | ajonas left #miro-hackers | |
| 14:50 | Jarrhead left #miro-hackers | |
| 14:52 | CarlFK left #miro-hackers | |
| 14:58 | willkg is now known as treebeard | |
| 14:58 | treebeard is now known as treebeardkg | |
| 14:59 | paulproteus | There we go. |
| 15:16 | CarlFK joined #miro-hackers | |
| 15:17 | janetPCF left #miro-hackers | |
| 15:21 | CarlFK left #miro-hackers | |
| 15:22 | janet joined #miro-hackers | |
| 15:36 | CarlFK joined #miro-hackers | |
| 15:40 | Jarrhead joined #miro-hackers | |
| 15:43 | zanoi | does anyone know if miro ever was able to parse gzipped feeds? |
| 15:45 | leenzada joined #miro-hackers | |
| 15:45 | treebeardkg | zanoi: it wasn't that i know of. |
| 15:47 | zanoi | treebeardkg: ok, thanks |
| 16:33 | bendk: you there? | |
| 16:35 | bendk | yup |
| 16:36 | zanoi | bendk: so it seems to me that the reason for bug 17600 is that Miro does not support any encoded feeds at all |
| 16:36 | as in, gzip or deflate encoded | |
| 16:36 | so I added support for that | |
| 16:37 | bendk | ahh |
| 16:37 | seems good | |
| 16:37 | does libcurl support that easily? | |
| 16:38 | zanoi | well what I did was decoding it before we pass it to feedparser |
| 16:39 | feedparser actually supports decoding it, but only if the header says it's gzipped/deflate, so if you download it before passing to feedparser, as we do, it doesn't decode it | |
| 16:39 | bendk | okay seems good to me |
| 16:39 | do you have a changeset I can look at? | |
| 16:39 | zanoi | i pushed it to the gzip branch, could you have a look whether you think its the right approach and if anything is missing? |
| 16:39 | i didn't add unittests for example | |
| 16:39 | bendk | sure |
| 16:40 | zanoi | also, i don't know if we now should send a different header with libcurl |
| 16:42 | it's just commit cf45e3160a | |
| 16:45 | bendk | I think we should put it somewhere before it gets to feed |
| 16:45 | because there's a lot of callbacks we would have to handle there | |
| 16:45 | like grab_url_callback() | |
| 16:46 | zanoi | ok |
| 16:46 | bendk | maybe in the on_finished() method of httpclient? |
| 16:47 | zanoi | sounds good |
| 17:05 | bendk: does 333efe2 look ok? | |
| 17:05 | and should I add unittests? | |
| 17:07 | bendk | I think it's good, but two things about exception handling: |
| 17:07 | 1) We usually just catch StandardError, which is basically all the regular errors, but not things like SystemExit and KeyboardInterrupt | |
| 17:07 | 2) I think we should log a warning if the decoding fails | |
| 17:08 | also unittests are always great. Unless there's something else pressing, I would add them | |
| 17:08 | zanoi | yes, I know catching Exception is bad, but this was how feedparser does it and I didn't want to take the chance of it being something else |
| 17:08 | I will try to find out what exception is thrown exactly and then catch that | |
| 17:09 | ok, i'll add the warnings | |
| 17:32 | Oraby left #miro-hackers | |
| 17:33 | Oraby joined #miro-hackers | |
| 17:44 | leenzada left #miro-hackers | |
| 17:45 | leenzada joined #miro-hackers | |
| 17:48 | bendk | zanoi: should that tab width change get cherry-picked into 4.0.2? |
| 17:48 | it seems pretty safe to me, but I want to double check | |
| 17:49 | also, what about the continuous playback changes? | |
| 17:50 | leenzada left #miro-hackers | |
| 17:52 | bendk | I think I'm going to take the tab width one, but not the playback ones |
| 17:52 | it seems like there's still the possibility that we haven't thought of all the user interactions | |
| 17:53 | tell me if that makes sense to you | |
| 18:35 | leenzada joined #miro-hackers | |
| 18:46 | zanoi | bendk: sorry, was heading home from cafe |
| 18:46 | I was going to ask you about cherry picking those changes | |
| 18:47 | bendk | I went ahead and cherry-picked all the ones except for the playback preference ones |
| 18:47 | zanoi | ok |
| 18:47 | bendk | tell me if you think those should be in there |
| 18:47 | I'm leaning against it, but I don't have that strong feelings | |
| 18:47 | maggie_s joined #miro-hackers | |
| 18:48 | zanoi | the only worry I have about the sidebar width is that I'm not sure whether the width could be different on different monitors |
| 18:49 | not it's always defaulting to the size it was when I started miro | |
| 18:49 | your cherry pick choices seem fine to me | |
| 19:13 | z3p | oh! |
| 19:13 | zanoi: I came across a problem with that | |
| 19:14 | if miro fails to start up, then there's no splitter object to get the width of | |
| 19:20 | zanoi | z3p: Is there a way to simulate that? should I just add a check whether the splitter exists? |
| 19:21 | z3p | zanoi: I was getting it when the 'database too new' error popped up |
| 19:21 | zanoi | ok |
| 19:21 | z3p | zanoi: the emusic branch has a new database migration if you need it |
| 19:21 | zanoi | thx |
| 19:24 | z3p: err..can't find any emusic branch | |
| 19:25 | z3p | zanoi: it's 'emusic-17544' |
| 19:27 | zanoi | nope, can't find it |
| 19:28 | z3p | oh, maybe I didn't push it |
| 19:29 | zanoi: try it now | |
| 19:29 | zanoi | thx |
| 19:31 | Jarrhead left #miro-hackers | |
| 19:55 | mattjohnson left #miro-hackers | |
| 20:09 | janet left #miro-hackers | |
| 20:16 | zanoi | bendk: I just cherry-picked a small fix into the 4.0 branch. Unfortunately I forgot to ask you beforehand |
| 20:22 | paulproteus | deardiary: more buckets!! http://ondemand.duke.edu/video[…]e-gets-buckets-20 |
| 20:23 | http://ondemand.duke.edu/video[…]gler-gets-buckets buckets buckets buckets! | |
| 20:29 | mattjohnson joined #miro-hackers | |
| 20:39 | zanoi | paulproteus: omgwtf |
| 20:40 | paulproteus | I *love* those videos. |
| 20:40 | zanoi | that guy isn't human |
| 20:53 | bendk | zanoi: I saw that, no problem |
| 20:54 | treebeardkg | deardiary: redid screenshots for miro user manual. think i'm finally done for this round. |
| 20:54 | deardiary: took about 4 hours to redo screenshots because the tools on osx that i was using totally blow. | |
| 20:54 | arpu joined #miro-hackers | |
| 20:55 | DGMurdockIII joined #miro-hackers | |
| 20:56 | treebeardkg | bendk: sorry i haven't looked at your subprocess stuff. i need a break, but then i'll look at it next. |
| 20:56 | bendk | no problem |
| 20:56 | treebeard huh? | |
| 20:57 | treebeardkg | oh, right... i'm treebeard. that's kind of funny because it's completely out of context here. |
| 20:57 | on #mediagoblin, all the cool people are taking on names from the Rings trilogy. | |
| 20:57 | so, there's that. | |
| 20:57 | fun and games on irc. | |
| 20:57 | afk a bit.... | |
| 20:59 | zanoi | and I was wondering where will was.... |
| 21:20 | treebeardkg | ok, i'm back. |
| 21:43 | z3p left #miro-hackers | |
| 22:06 | treebeardkg | gah... it's tuesday night already. |
| 22:07 | kcw joined #miro-hackers | |
| 22:09 | maggie_s left #miro-hackers | |
| 22:32 | kcw_ joined #miro-hackers | |
| 22:34 | kcw left #miro-hackers | |
| 22:34 | Oraby left #miro-hackers | |
| 22:34 | Oraby joined #miro-hackers | |
| 22:37 | leenzada left #miro-hackers | |
| 23:10 | Oraby left #miro-hackers | |
| 23:58 | CarlFK left #miro-hackers | |
| 23:58 | CarlFK joined #miro-hackers |