All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:04 | glee joined #miro-hackers | |
| 04:10 | maggie_s joined #miro-hackers | |
| 07:33 | janet joined #miro-hackers | |
| 10:30 | Jarrhead joined #miro-hackers | |
| 10:42 | arpu joined #miro-hackers | |
| 12:11 | errado joined #miro-hackers | |
| 13:01 | z3p | good morning |
| 13:04 | arpu joined #miro-hackers | |
| 14:01 | errado joined #miro-hackers | |
| 14:16 | GitHub181 joined #miro-hackers | |
| 14:16 | GitHub181 | [miro] paulswartz created bz18175 (+1 new commit): https://github.com/pculture/miro/compare/0c1a603^...0c1a603 |
| 14:16 | [miro/bz18175] 18175. don't overwrite existing synced files - Paul Swartz | |
| 14:16 | GitHub181 left #miro-hackers | |
| 14:19 | z3p | bendk: glee: can one of you take a look at https://github.com/pculture/miro/pull/1 ? |
| 14:19 | bendk | sure |
| 14:21 | looks good to me | |
| 14:22 | z3p | bendk: thanks |
| 14:23 | GitHub181 joined #miro-hackers | |
| 14:23 | GitHub181 | [miro] paulswartz pushed 1 new commit to master: https://github.com/pculture/mi[…]b4d17f86c522279a1 |
| 14:23 | [miro/master] Merge pull request #1 from pculture/bz18175 - Paul Swartz | |
| 14:23 | GitHub181 left #miro-hackers | |
| 14:35 | ajonas joined #miro-hackers | |
| 15:17 | GitHub162 joined #miro-hackers | |
| 15:17 | GitHub162 | [miro] zanoi force-pushed autoupdate from 1625d43 to e9396a1: https://github.com/pculture/mi[…]ommits/autoupdate |
| 15:17 | [miro/autoupdate] 18183. Make NSIS default to current installation directory if Miro is installed. - Jonas Emanuel Mueller | |
| 15:17 | GitHub162 left #miro-hackers | |
| 15:19 | zanoi | could someone please review that last commit |
| 15:21 | GitHub154 joined #miro-hackers | |
| 15:21 | GitHub154 | [miro] paulswartz created bz18188 (+1 new commit): https://github.com/pculture/miro/compare/be0c3e4^...be0c3e4 |
| 15:21 | [miro/bz18188] 18188. AttributeError: 'NoneType' object has no attribute 'rfind' - Paul Swartz | |
| 15:21 | GitHub154 left #miro-hackers | |
| 15:23 | z3p | bendk: ^ as well |
| 15:23 | bendk: I can do some reviews for you on Monday to make up for this | |
| 15:24 | bendk | seems good to me |
| 15:25 | GitHub84 joined #miro-hackers | |
| 15:25 | GitHub84 | [miro] paulswartz pushed 1 new commit to master: https://github.com/pculture/mi[…]f1e9a3bac3657784a |
| 15:25 | [miro/master] Merge pull request #2 from pculture/bz18188 - Paul Swartz | |
| 15:25 | GitHub84 left #miro-hackers | |
| 15:58 | errado joined #miro-hackers | |
| 16:16 | mattjohnson joined #miro-hackers | |
| 16:30 | arpu joined #miro-hackers | |
| 18:14 | janet | bendk: z3p did one of you check the autoupdate fix that zanoi made? |
| 18:14 | it's the most important fix left for the winsparkle stuff and I'd love to test it tonight if possible | |
| 18:15 | z3p | janet: I didn't know it was supposed to get reviewed; it's not in master, or a request |
| 18:15 | janet: but I can go test it out | |
| 18:22 | zanoi | z3p: oh, do you want me to make a pull request? I just wrote it here in the channel |
| 18:22 | z3p | zanoi: I just didn't see it |
| 18:23 | zanoi: I'm looking at it now | |
| 18:29 | CarlFK joined #miro-hackers | |
| 18:34 | z3p | zanoi: looks good |
| 18:34 | zanoi | k |
| 18:35 | z3p: there is one thing that sucks, on line 1181 the INSTDIR can theoretically be overwritten | |
| 18:36 | z3p | zanoi: sure, but that's for themes; not many people are using them any more |
| 18:36 | zanoi | but I'm not sure when that's supposed to kick in. in testing it doesn't |
| 18:36 | yes | |
| 18:36 | so you thinks it's fine? | |
| 18:36 | z3p | zanoi: I wouldn't worry about it |
| 18:36 | zanoi | kk |
| 18:40 | janet | zanoi: when that merges into master - I'll rerun the nightlies and check that stuff out |
| 18:40 | testing the winsparkle on win7 today and all looks fine | |
| 18:40 | zanoi | janet: yay |
| 18:42 | GitHub14 joined #miro-hackers | |
| 18:42 | GitHub14 | [miro] zanoi pushed 1 new commit to master: https://github.com/pculture/mi[…]5804f3f5113bf309b |
| 18:42 | [miro/master] 18183. Make NSIS default to current installation directory if Miro is installed. - Jonas Emanuel Mueller | |
| 18:42 | GitHub14 left #miro-hackers | |
| 19:08 | maggie_s joined #miro-hackers | |
| 19:26 | janet1 joined #miro-hackers | |
| 19:57 | maggie_s | melinath: hi! |
| 20:10 | ajonas | hi maggie_s ! |
| 20:10 | maggie_s | hi ajonas! |
| 20:41 | janet1 | zanoi: the winsparkle stuff is great on XP and Win 7 - I catch vista later or tomorrow - but I'm less worried since it's the middle os. And detecting the previous install is good too. |
| 20:41 | I added a comment to bug http://bugzilla.pculture.org/s[…]_bug.cgi?id=18065 | |
| 20:41 | about the delay | |
| 20:41 | I don't know if you added it yet - but I think it should be a bit longer if you have | |
| 20:48 | melinath | maggie_s hi |
| 20:49 | maggie_s | melinath: just wanted to ask you to look into a couple of MC bugs when you have some spare time |
| 20:49 | melinath: I've sent you an email about it | |
| 20:51 | melinath | maggie_s: Sure. I'm off this week at a conference, but I can look at it when I get back |
| 20:52 | maggie_s | melinath: thanks a lot! so you are not in WA now, right? |
| 21:00 | zanoi | janet1: nope, sorry have not added the delay yet. Turned out to be more work than I thought |
| 21:01 | janet1 | ok |
| 21:01 | zanoi | janet1: also the way the code works now is that it checks it is Vista or later and either launches the update using the standard winsparkle code or one that takes UAC into account |
| 21:03 | janet1 | ok - well xp and 7 both work - so I'll check vista later. Plus that one has a D: drive that I want to double check the install dir checking. |
| 21:03 | zanoi | janet1: my point being that it would be great if you could test on the borderline area to see that it draws the line and the correct place. Which basically means testing on Vista :) |
| 21:03 | janet1 | I'm curious why your install changes don't fix http://bugzilla.pculture.org/s[…]_bug.cgi?id=10289 - |
| 21:04 | for the dir checking - but maybe that's outside the scope of what you are doing | |
| 21:04 | And I'm curious how winsparkle is smart enough to know the 4.1 version should be more recent than 4.1-git. | |
| 21:04 | melinath | maggie_s: in Portland |
| 21:04 | zanoi | janet1: they should fix 10289! if not then something is wrong |
| 21:05 | oh wait | |
| 21:05 | maybe not | |
| 21:05 | maggie_s | melinath: ah, that's pretty far. so you surely didn't feel the quake |
| 21:05 | zanoi | I only tested whether the advanced install now defaults to the current install path |
| 21:06 | but I would have though it works with easy install as well | |
| 21:06 | janet1 | zanoi: that ticket is probably even more trivial now that winsparkle handles the update |
| 21:10 | zanoi | janet1: looking at the winsparkle code it seems to take into account that version numbers with strings at the end are lower. For example 1.5beta 3 is lower than 1.5 |
| 21:10 | janet1 | good to know - I was pretty impressed when it worked - I was worried about users getting stuck on the beta channel |
| 21:10 | zanoi | that is actually quite intelligent :) |
| 21:11 | but in the worst case we can add our old serials | |
| 21:12 | ajonas | maggie_s: you had an earthquake? |
| 21:13 | maggie_s | ajonas: 6.7 west of Vancouver Island... but I felt nothing |
| 21:13 | ajonas | maggie_s: i felt left out when i didn't feel the east coast one, but it's probably good |
| 21:15 | maggie_s | ajonas: sure, as West Coasters we shouldn't get too excited about such stuff - we just haven't had anything for quite a while |
| 21:16 | ajonas | heading out for a bit, night all |
| 21:18 | zanoi | janet1: the time winsparkle waits with launching the installer after sending a kill signal to miro is kind of arbitrary. You might want to have a look whether you think it should be chahnged |
| 21:19 | right now I think it sends the kill signal, waits 10 seconds and either launches the installer, or if miro is still running sends a forcekill signal and waits 10 seconds again | |
| 21:19 | melinath | maggie_s: Nope, didn't feel it |
| 21:19 | zanoi | and after that it either launches the installer or, if miro is still running, aborts with an error message |
| 21:20 | point being, right now the user has to wait min. 10 seconds, and if he is unlucky 20 seconds before he gets feedback from the update | |
| 21:20 | which could be a long time, i don't really know | |
| 21:21 | maggie_s | melinath: me, neither - they say it could be felt only on upper floors |
| 21:32 | zanoi | janet1: are you sure 10289 isn't fixed by my change? I just tried it and it seemed to work fine |
| 21:35 | arpu joined #miro-hackers | |
| 21:40 | z3p | janet1: you should be good for unisubs now |
| 23:47 | willkg joined #miro-hackers |