All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 03:58 | Odysimus joined #miro-hackers | |
| 06:30 | maggie_s joined #miro-hackers | |
| 06:39 | Jarrhead joined #miro-hackers | |
| 08:08 | janet1 joined #miro-hackers | |
| 08:20 | janet joined #miro-hackers | |
| 08:35 | janet1 joined #miro-hackers | |
| 13:14 | willkg joined #miro-hackers | |
| 13:32 | willkg | hi! |
| 14:04 | janet joined #miro-hackers | |
| 14:30 | z3p joined #miro-hackers | |
| 14:46 | Jarrhead joined #miro-hackers | |
| 16:39 | Jarrhead joined #miro-hackers | |
| 17:03 | z3p | melinath: ping me when you get in; I'd like to talk about merging the feeds/vidscraper_purge branches |
| 17:31 | janet joined #miro-hackers | |
| 18:51 | janet1 joined #miro-hackers | |
| 19:07 | janet joined #miro-hackers | |
| 19:13 | GitHub52 joined #miro-hackers | |
| 19:13 | GitHub52 | [miro] kazcw pushed 2 new commits to master: https://github.com/pculture/mi[…]89c7b89...f26bf58 |
| 19:13 | [miro/master] bz18390: Nuke datastructures.py. - Geoffrey Lee | |
| 19:13 | [miro/master] Merge pull request #49 from geoffl/bz18390 - kazcw | |
| 19:13 | GitHub52 left #miro-hackers | |
| 19:15 | Odysimus joined #miro-hackers | |
| 19:18 | melinath | z3p: in |
| 19:19 | z3p | melinath: hey |
| 19:19 | melinath: so actually, I'm not as close as I thought | |
| 19:19 | melinath: a bunch of the MC tests don't pass | |
| 19:20 | melinath | z3p: a bunch of MC tests didn't pass when that branch started. |
| 19:22 | z3p: well, actually, the basic tests all passed, probably, but the admin tests didn't. | |
| 19:23 | z3p: If you can get them passing, great. | |
| 19:23 | z3p | melinath: sure |
| 19:23 | melinath: but the feed import tests aren't passing, which is a problem | |
| 19:23 | melinath | z3p: hmm |
| 19:23 | z3p | melinath: partially it's how update_items() has changed |
| 19:23 | melinath | z3p: Yeah, that's a problem. |
| 19:23 | z3p | melinath: but partly it's functionality which hasn't been completely replicated |
| 19:24 | melinath | z3p: like what? |
| 19:26 | z3p | melinath: not getting all the data out of generic feeds, some unescaping |
| 19:27 | melinath: not a huge deal, it's all fixable | |
| 19:27 | melinath | z3p: Mm. Yay for tests doing what they're supposed to do. :-) |
| 19:28 | z3p: But shouldn't those tests be in vidscraper? | |
| 19:28 | z3p: maybe move them over? | |
| 19:28 | z3p | melinath: mostly, yes |
| 19:29 | melinath: but I'm going to get them working first, then move them | |
| 19:30 | melinath | z3p: cool cool. |
| 19:30 | z3p | melinath: but if there's anything big that you think is standing in the way of merging those branches, now would be a good time to bring it up :) |
| 19:32 | off to the gym; back in an hour or so | |
| 19:34 | janet1 joined #miro-hackers | |
| 19:59 | melinath | z3p: I think that they're fine to merge. |
| 20:01 | z3p: scraped_feeds does provide scraped feeds and vidscraper_purge does purge vidscraper code doubling. | |
| 20:01 | z3p: Any additional work can be done either on the development branches or in new feature branches. | |
| 20:14 | uwe_mobile joined #miro-hackers | |
| 20:50 | maggie_s joined #miro-hackers | |
| 21:07 | melinath | z3p: Is there anything you still want to do before merging vidscraper_purge and scraped_feeds? |
| 21:48 | z3p | melinath: just make sure the tests still pass |