All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:00 | melinath | z3p: SavedSearchImportTestCase.test_update_ignore_duplicates is failing for me, along with a couple others - mark_import_complete is throwing MaxRetriesExceeded. |
| 00:00 | failing => erroring | |
| 00:00 | z3p | melinath: do you have an updated vidscraper? |
| 00:02 | melinath | z3p: I was missing the latest dev commit, but that shouldn't be causing this... and pulling that commit doesn't fix it. |
| 00:05 | z3p | melinath: hrm |
| 00:05 | melinath: do they pass in the release branch? | |
| 00:06 | melinath: also, I'm seeing the maxretries stuff, but it isn't erroring the tests for am e | |
| 00:06 | *me | |
| 00:08 | melinath | z3p: nope, not passing on the release branch for me, either. |
| 00:12 | arpu joined #miro-hackers | |
| 00:17 | melinath | z3p: not sure why this didn't crop up earlier, but there's been a bug in the savedsearch imports for a while now. |
| 00:17 | z3p | melinath: huh; they're passing for me |
| 00:17 | melinath | z3p: they only work if there are results from only one suite |
| 00:17 | z3p: do you have vimeo keys installed? | |
| 00:19 | z3p | melinath: yeah |
| 00:19 | melinath | z3p: Are you running an actual celery server? (I'm running the tests on always_eager.) |
| 00:20 | the problem exists either way | |
| 00:20 | I'm just curious why it's passing for you. | |
| 00:20 | z3p | melinath: nope; CELERY_ALWAYS_EAGER = ('test' in sys.argv) |
| 00:20 | melinath | hmm |
| 00:21 | z3p | melinath: is that the only test that's failing for you? |
| 00:22 | melinath | z3p: The problem I'm seeing is this: One SearchImport is created for each search suite import. After importing the first search suite, the import is marked as "complete" - so when the second import runs, mark_import_pending can't find the searchimport instance. |
| 00:23 | Unrelatedly, it looks like the video we're testing with no longer exists. | |
| 00:24 | z3p: All 4 SavedSearchImport tests are failing for me with that error. | |
| 00:28 | z3p: The VotingTestCase is also erroring out for me, but I think that's unrelated (and I don't care nearly as much whether voting is working) | |
| 00:29 | hmm | |
| 00:29 | z3p | melinath: you're right; I'm seeing WARNING Retrying u'http://www.youtube.com/watch?v=Gf6_5Eg9PFQ': expected SearchImport instance (pk=1) missing. |
| 00:29 | melinath: but not an error about the retry failing | |
| 00:30 | melinath | ah... |
| 00:30 | z3p | melinath: perhaps do you have CELERY_EAGER_PROPAGATES_EXCEPTIONS on? |
| 00:30 | melinath | do you have CELERY_EAGER_PROPAGATES_EXCEPTIONS = True |
| 00:30 | cause I do | |
| 00:30 | z3p | nope |
| 00:31 | I'll bet it fails now though | |
| 00:31 | melinath | well |
| 00:31 | that would explain it. | |
| 00:32 | z3p | melinath: yep, there are some errors |
| 00:33 | melinath: why not alter the savedsearch updates to use one iterable, the way it used to? | |
| 00:34 | melinath | z3p: I think there was a good reason not to do it the way it had been done... |
| 00:35 | z3p: Don't remember exactly why, though. | |
| 00:37 | z3p | melinath: I can't think of any obvious way to implement the 'failed' behavior |
| 00:37 | I guess you could do it at the end of the iterator | |
| 00:38 | if nothing was iterated | |
| 00:38 | and really, I mean generator | |
| 00:40 | melinath | z3p: I think that just itertools.chaining the video_iters that load should work |
| 00:40 | z3p | melinath: true; we alternated before, but chaining should work too, except for knowing if anything happened |
| 00:41 | melinath: but we could change 'update()' to return the number of videos | |
| 00:41 | melinath: and then check afterwards | |
| 00:41 | melinath | z3p: knowing if anything happened? |
| 00:41 | z3p | melinath: if any of the iterators yielded videos |
| 00:41 | melinath: (the current behavior) | |
| 00:41 | melinath | z3p: we don't currently check that |
| 00:41 | z3p: or do you mean currently in master? | |
| 00:42 | z3p | melinath: currently in the release branch |
| 00:42 | https://github.com/pculture/mi[…]v/models.py#L1088 | |
| 00:43 | melinath: well, I guess also in master since you merged the release branch :) | |
| 00:43 | melinath | :-p yeah... |
| 00:43 | z3p: That's an easy check | |
| 00:45 | https://gist.github.com/1714245 | |
| 00:45 | ^ testing | |
| 00:46 | z3p | melinath: yep, that works too |
| 00:46 | melinath: fyi, I checked some more things into the release branch | |
| 00:47 | melinath | z3p: gotta love those thumbnail_updated tests |
| 00:48 | okay, search import passes with those changes. | |
| 00:48 | z3p | melinath: yeah... |
| 00:50 | so that's 8 fewer failures now! | |
| 01:03 | melinath | z3p: http://pastebin.ca/2108449 |
| 01:04 | ^ Test results | |
| 01:04 | z3p | melinath: shoiuld have ViewTestCase fixes shortly |
| 01:05 | melinath | kk |
| 01:12 | z3p | melinath: pushed to release |
| 01:12 | melinath: do you have 'localtv.comments' as your comment app? | |
| 01:15 | melinath: guess not, I see the same issue without it | |
| 01:17 | melinath | z3p: Great. Then if there are no further objections...? |
| 01:18 | z3p | melinath: let me merge my last changes into master, then nope |
| 01:18 | melinath | z3p: Already merged them |
| 01:19 | z3p: nm | |
| 01:19 | z3p: You have other last changes. | |
| 01:19 | z3p: Could you update the 1.8 tag as well? | |
| 01:21 | z3p | melinath: done; https://github.com/pculture/mi[…]unity/commits/1.8 |
| 01:24 | melinath | MC 1.8 is now officially released. |
| 01:24 | z3p | woo! |
| 01:25 | * melinath | starts the party music. |
| 01:56 | CarlFK joined #miro-hackers | |
| 05:03 | CarlFK joined #miro-hackers | |
| 05:49 | janet joined #miro-hackers | |
| 05:50 | paroneayea joined #miro-hackers | |
| 06:34 | testerguy7 left #miro-hackers | |
| 06:36 | janet joined #miro-hackers | |
| 09:20 | testerguy7 joined #miro-hackers | |
| 09:33 | janet joined #miro-hackers | |
| 09:38 | CarlFK joined #miro-hackers | |
| 10:15 | janet joined #miro-hackers | |
| 10:36 | arpu joined #miro-hackers | |
| 13:23 | testerguy7 left #miro-hackers | |
| 14:12 | janet | hey glee I was hoping to look at the donateimpl branch on ubuntu, but the the test windows doesn't open |
| 14:13 | glee | janet: one second let me check |
| 14:17 | willkg joined #miro-hackers | |
| 14:18 | glee | janet: Opens for me, anything in the log? |
| 14:18 | janet | no |
| 14:19 | hold on let me go retry | |
| 14:22 | nope - run donate popup | |
| 14:22 | no windows | |
| 14:23 | no messages | |
| 14:28 | glee | janet: can you run git log | head −1 and see what it shows? |
| 14:29 | janet | glee: sure |
| 14:30 | glee: 609ef….. | |
| 14:31 | glee | janet: |
| 14:31 | nothing in console? | |
| 14:31 | janet | what do you mean? |
| 14:32 | glee | janet: the logs. Nothing in the logs? Are you sure the window's not just hidden behind somewhere? |
| 14:32 | janet: also have you tried with a fresh db/prefs? | |
| 14:33 | janet | I will now - I'm having the same problem on osx |
| 14:33 | glee | janet: can you pastebin the logs somewhere anyway? Just so I can double check |
| 14:33 | janet | I just updated from 4.0.6 |
| 14:33 | sure | |
| 14:34 | let me start over and see | |
| 14:38 | glee | janet: Also, when you type in the url, did you give the full scheme? Did you simply type www.google.com or did you use http://www.google.com? The former won't work, I think |
| 14:38 | janet | glee: It doesn't even show me the windows |
| 14:38 | so I've got nothing to type in | |
| 14:39 | Dev -> Run Donate Popup | |
| 14:39 | no popup | |
| 14:39 | glee | janet: run the powertoys, I think that might have been a bad merge |
| 14:40 | janet | oh - sorry |
| 14:40 | blindness | |
| 14:40 | forgot the name | |
| 14:41 | GitHub137 joined #miro-hackers | |
| 14:41 | GitHub137 | [miro] geoffl force-pushed donateimpl from 609ef5b to 1f95535: https://github.com/pculture/mi[…]ommits/donateimpl |
| 14:41 | [miro/donateimpl] Donate Manager implementation. - Geoffrey Lee | |
| 14:41 | GitHub137 left #miro-hackers | |
| 15:36 | CarlFK joined #miro-hackers | |
| 15:54 | janet joined #miro-hackers | |
| 15:55 | janet joined #miro-hackers | |
| 16:00 | janet | glee: is the timed ask implemented? |
| 16:00 | glee | janet: All counters are reset after 180 days |
| 16:00 | janet | ok |
| 16:01 | glee | janet: If the current time - last donate time > half a year then counters are reset. This is done on startup |
| 16:01 | janet | ok - just going back to the future |
| 16:50 | paroneayea joined #miro-hackers | |
| 16:57 | paroneayea joined #miro-hackers | |
| 17:06 | arpu joined #miro-hackers | |
| 19:10 | glee joined #miro-hackers | |
| 19:28 | janet joined #miro-hackers | |
| 19:35 | janet joined #miro-hackers | |
| 19:40 | bendk | janet: you around? |
| 19:41 | What does "swch" mean in this ticket http://bugzilla.pculture.org/s[…]_bug.cgi?id=18541 | |
| 19:42 | z3p | bendk: the swedish chef translation |
| 19:43 | janet joined #miro-hackers | |
| 19:43 | janet | sorry bendk got kicked fof |
| 19:43 | swch is the test translation that will created for testing translated strings | |
| 19:44 | bendk | ahh, awesome |
| 19:44 | janet | swedish chef - I believe stands for |
| 19:56 | bendk: I seem to be able to reproduce most the bugs I've filed before - regarding weird and broken thumbs | |
| 19:57 | running echonest on video files | |
| 19:57 | codegen crashes | |
| 19:57 | codegen.Darwin using massive amounts of cpu | |
| 19:57 | is there any extra info I can give you right now? | |
| 19:59 | Version 5.0-git (99902c03) | |
| 20:07 | arpu joined #miro-hackers | |
| 20:21 | janet1 joined #miro-hackers | |
| 20:33 | testerguy7 joined #miro-hackers | |
| 20:38 | testerguy7 joined #miro-hackers | |
| 20:39 | testerguy7 joined #miro-hackers | |
| 21:08 | rikai joined #miro-hackers | |
| 21:08 | rikai joined #miro-hackers | |
| 21:14 | bendk | janet1: how recent was the database you just posted in #18634 upgraded? |
| 21:14 | janet1 | right now |
| 21:14 | I did a fresh install of 4.0.6 | |
| 21:14 | imported data from itunes and 1 other folder | |
| 21:15 | let it all import then updated to today nightlies | |
| 21:15 | it's still doing the metadata lookup | |
| 21:15 | I'm a bit puzzled by how it works | |
| 21:15 | I'm currently importing 642 or 1200 something - | |
| 21:16 | I've shutdown and restarted for various reasons so I guess that's what's left | |
| 21:16 | but there are some items that have entries in the metadata table for artist or album - but I don't see that information reflected in the displayed metadata | |
| 21:19 | or for example there are 4311 items in the metadata table that have a source listed as echonest. | |
| 21:27 | bendk | janet1: it's all messed up right now |
| 21:27 | janet1 | oh ok - |
| 21:27 | bendk | I have a changeset to fix things |
| 21:28 | janet1 | makes me feel better as I sit here completely puzzled trying to understand it all |
| 21:29 | what does S, C, F … mean in the metadata_status table for moviedata_status, echonest_status etc. | |
| 21:32 | GitHub94 joined #miro-hackers | |
| 21:32 | GitHub94 | [miro] bendk created metadatasweep (+5 new commits): https://github.com/pculture/miro/compare/d80fbfc^...cb00140 |
| 21:32 | [miro/metadatasweep] Fix for on_new_metadata() - Ben Dean-Kawamura | |
| 21:32 | [miro/metadatasweep] Run pending metadata updates on shutdown - Ben Dean-Kawamura | |
| 21:32 | [miro/metadatasweep] bz18541: Don't store displaytext output in ItemInfo - Ben Dean-Kawamura | |
| 21:32 | GitHub94 left #miro-hackers | |
| 21:32 | bendk | S == skipped |
| 21:32 | C = complete | |
| 21:32 | F = failure | |
| 21:33 | janet1: I just pushed the metadatasweep branch | |
| 21:33 | I think it should fix all the issues | |
| 21:33 | janet1 | oh good |
| 21:34 | bendk | can you make an OSX build for NPR somewhere along the line? |
| 21:34 | GitHub158 joined #miro-hackers | |
| 21:34 | GitHub158 | [miro] bendk force-pushed metadatasweep from cb00140 to 66227cd: https://github.com/pculture/mi[…]its/metadatasweep |
| 21:34 | [miro/metadatasweep] bz18634: Fix for cover_art_path database upgrade. - Ben Dean-Kawamura | |
| 21:34 | GitHub158 left #miro-hackers | |
| 21:35 | janet1 | sure can |
| 21:50 | maggie_s joined #miro-hackers | |
| 21:56 | janet1 | bendk: http://nightlies.pculture.org/[…]sweep-nightly.dmg |